[CALCITE-6684] Arrow adapter should supports filter conditions of Decimal type #4043
Conversation
caicancai
changed the title
| @@ -194,6 +194,8 @@ private static TreeNode makeLiteralNode(String literal, String type) { | |||
| return TreeBuilder.makeLiteral(parseFloat(literal)); | |||
| case "double": | |||
| return TreeBuilder.makeLiteral(parseDouble(literal)); | |||
| case "decimal": | |||
| return TreeBuilder.makeDecimalLiteral(literal, 19, 0); | |||
There was a problem hiding this comment.
Comply with Calcite's default Decimal type
There was a problem hiding this comment.
You should use the type system to retrieve the default type, assuming it is available here.
Maybe there is a default type for Arrow, but the "default" type for Calcite is irrelevant in this context.
| private static String getLiteralType(Object literal, RelDataType type) { | ||
| if (type.getSqlTypeName() == SqlTypeName.DECIMAL) { | ||
| return "decimal"; | ||
| } else if (literal instanceof BigDecimal) { |
There was a problem hiding this comment.
since now you are passing type information to this function you should use it everywhere. There is no reason to guess the type based on the Java type of the literal.
|
| @@ -194,6 +194,8 @@ private static TreeNode makeLiteralNode(String literal, String type) { | |||
| return TreeBuilder.makeLiteral(parseFloat(literal)); | |||
| case "double": | |||
| return TreeBuilder.makeLiteral(parseDouble(literal)); | |||
| case "decimal": | |||
| return TreeBuilder.makeDecimalLiteral(literal, 19, 0); | |||
There was a problem hiding this comment.
You should use the type system to retrieve the default type, assuming it is available here.
Maybe there is a default type for Arrow, but the "default" type for Calcite is irrelevant in this context.
| } else if (type.getSqlTypeName() == SqlTypeName.VARCHAR | ||
| || type.getSqlTypeName() == SqlTypeName.CHAR) { | ||
| return "string"; | ||
| } else { |
There was a problem hiding this comment.
there are many unhandled cases, but perhaps this is a good start.
https://issues.apache.org/jira/browse/CALCITE-6684