Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-4351] Add github action for building #4358

Merged
merged 4 commits into from
Oct 5, 2024

Conversation

kevinjmh
Copy link
Member

@kevinjmh kevinjmh commented Sep 29, 2024

Why is this PR needed?

build the project automatically #4351

What changes were proposed in this PR?

Add github action for building the project.
Revert unfinished WIP commits about geo module to make sure building is success.

see:
https://github.com/apache/carbondata/actions/runs/11090247913

image
image

Does this PR introduce any user interface change?

  • No
  • Yes. (please explain the change and update document)

Is any new testcase added?

  • No
  • Yes

@chenliang613
Copy link
Contributor

Thanks for contribute this pull request. looks good to me

@chenliang613
Copy link
Contributor

please other committer review it

@xubo245
Copy link
Contributor

xubo245 commented Sep 29, 2024

LGTM

@kevinjmh
Copy link
Member Author

add: Cache thrift binary to skip the building work. See difference between attempt1 and attempt2:

Attempt 1
image

Attempt 2
image

@chenliang613
Copy link
Contributor

LGTM

@chenliang613 chenliang613 merged commit e0ac69a into apache:master Oct 5, 2024
3 checks passed
@kevinjmh kevinjmh deleted the add_action branch October 9, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants