Skip to content

Cassandra 14227 trunk #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+19 −9
Open

Cassandra 14227 trunk #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions ttl_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import os
import time
import datetime

import pytest
import logging

Expand Down Expand Up @@ -365,8 +367,11 @@ def test_expiration_overflow_policy_reject_default_ttl(self):
def _base_expiration_overflow_policy_test(self, default_ttl, policy):
"""
Checks that expiration date overflow policy is correctly applied
@jira_ticket CASSANDRA-14092
@jira_ticket CASSANDRA-14092 and CASSANDRA-14227
"""
# Post 5.0 TTL may overflow in 2038 (legacy) or 2106 C14227
overflow_policy_applies = "NONE" != self.cluster.nodelist()[0].get_conf_option("storage_compatibility_mode") \
or datetime.date.today().year >= 2086
MAX_TTL = 20 * 365 * 24 * 60 * 60 # 20 years in seconds
default_time_to_live = MAX_TTL if default_ttl else None
self.prepare(default_time_to_live=default_time_to_live)
Expand All @@ -384,9 +389,9 @@ def _base_expiration_overflow_policy_test(self, default_ttl, policy):
try:
result = self.session1.execute_async(query + ";")
result.result()
if policy == 'REJECT':
if policy == 'REJECT' and overflow_policy_applies:
pytest.fail("should throw InvalidRequest")
if self.cluster.version() >= '3.0': # client warn only on 3.0+
if self.cluster.version() >= '3.0' and overflow_policy_applies: # client warn only on 3.0+
if policy == 'CAP':
logger.debug("Warning is {}".format(result.warnings[0]))
assert 'exceeds maximum supported expiration' in result.warnings[0], 'Warning not found'
Expand All @@ -399,10 +404,10 @@ def _base_expiration_overflow_policy_test(self, default_ttl, policy):

self.cluster.flush()
# Data should be present unless policy is reject
assert_row_count(self.session1, 'ttl_table', 0 if policy == 'REJECT' else 1)
assert_row_count(self.session1, 'ttl_table', 0 if (policy == 'REJECT' and overflow_policy_applies) else 1)

# Check that warning is always logged, unless policy is REJECT
if policy != 'REJECT':
if policy != 'REJECT' and overflow_policy_applies:
node1 = self.cluster.nodelist()[0]
prefix = 'default ' if default_ttl else ''
warning = node1.grep_log("Request on table {}.{} with {}ttl of {} seconds exceeds maximum supported expiration"
Expand Down Expand Up @@ -599,7 +604,11 @@ def test_recover_negative_expiration_date_sstables_with_scrub(self):
node.watch_log_for('Loading new SSTables', timeout=10)

logger.debug("Check that there are no rows present")
assert_row_count(session, 'ttl_table', 0)
# CASSANDRA-14227 5.0 upwards we have long TTL that can read overflowed rows
if self.cluster.version() >= '5.0':
assert_row_count(session, 'ttl_table', 1)
else:
assert_row_count(session, 'ttl_table', 0)

logger.debug("Shutting down node")
self.cluster.stop()
Expand Down
7 changes: 4 additions & 3 deletions upgrade_tests/upgrade_through_versions_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,7 @@ def upgrade_scenario(self, populate=True, create_schema=True, rolling=False, aft

self.upgrade_to_version(version_meta, partial=True, nodes=(node,), internode_ssl=internode_ssl)

logger.debug(str(self.fixture_dtest_setup.subprocs))
self._check_on_subprocs(self.fixture_dtest_setup.subprocs)
logger.debug('Successfully upgraded %d of %d nodes to %s' %
(num + 1, len(self.cluster.nodelist()), version_meta.version))
Expand Down Expand Up @@ -488,7 +489,7 @@ def _check_on_subprocs(self, subprocs):
if not all(subproc_statuses):
message = "A subprocess has terminated early. Subprocess statuses: "
for s in subprocs:
message += "{name} (is_alive: {aliveness}), ".format(name=s.name, aliveness=s.is_alive())
message += "{name} (is_alive: {aliveness}, exitCode: {exitCode}), ".format(name=s.name, aliveness=s.is_alive(), exitCode=s.exitcode)
message += "attempting to terminate remaining subprocesses now."
self._terminate_subprocs()
raise RuntimeError(message)
Expand Down Expand Up @@ -654,7 +655,7 @@ def _start_continuous_write_and_verify(self, wait_for_rowcount=0, max_wait_s=600
# queue of verified writes, which are update candidates
verification_done_queue = Queue(maxsize=500)

writer = Process(target=data_writer, args=(self, to_verify_queue, verification_done_queue, 25))
writer = Process(name="data_writer", target=data_writer, args=(self, to_verify_queue, verification_done_queue, 25))
# daemon subprocesses are killed automagically when the parent process exits
writer.daemon = True
self.fixture_dtest_setup.subprocs.append(writer)
Expand All @@ -663,7 +664,7 @@ def _start_continuous_write_and_verify(self, wait_for_rowcount=0, max_wait_s=600
if wait_for_rowcount > 0:
self._wait_until_queue_condition('rows written (but not verified)', to_verify_queue, operator.ge, wait_for_rowcount, max_wait_s=max_wait_s)

verifier = Process(target=data_checker, args=(self, to_verify_queue, verification_done_queue))
verifier = Process(name="data_checker", target=data_checker, args=(self, to_verify_queue, verification_done_queue))
# daemon subprocesses are killed automagically when the parent process exits
verifier.daemon = True
self.fixture_dtest_setup.subprocs.append(verifier)
Expand Down