-
Notifications
You must be signed in to change notification settings - Fork 630
CASSGO-29, refactor packages to separate internal and public API #1857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
e14dad0
to
83b8c1a
Compare
@joao-r-reis could you please check the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot 👍 it's a very good foundation so that future code can be written with this internal
vs public
structure in mind and doesn't change anything on the public API.
Anything more than this at a single time will require a lot of effort and I think doing things this way with small steps at a time will work better 👍
Great. So, I will clean up a little bit, and we can push it to merge, or we keep developing this PR? I think that merging would be better, to avoid future conflicts with new features, anyway its a good start point. |
83b8c1a
to
8408080
Compare
@joao-r-reis, I have upgraded it a little, but I think we should pause it until big PRs are merged, such as CASSGO-1, CASSGO-4, etc. |
Honestly it might even be worth delaying this until 2.1 release, we don't want to do any api breaking changes with this PR anyway |
Also I thought this PR was already good enough to merge, I have to retract my +1 until I can review it again since you made some changes |
Oh, sorry. I thought that we should move everything that doesn't expose to a user to the internal package in this PR, because there are a lot of things left to move. |
Closes #465