Allow users to send requests from CMK using POST requests. #161
Conversation
rohityadavcloud
requested review from
shwstppr,
vishesh92,
Pearl1594 and
sureshanaparti
config/config.go
Outdated
| @@ -282,6 +284,9 @@ func saveConfig(cfg *Config) *Config { | |||
| core.AutoComplete = true | |||
| core.Output = JSON | |||
| } | |||
| if !conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { | |||
| core.PostRequest = true | |||
There was a problem hiding this comment.
default PostRequest is true, so should set to false here when "postrequest" key not present?
There was a problem hiding this comment.
Good point @sureshanaparti. @kevin-lii can you please check this?
| @@ -204,6 +204,8 @@ func NewAPIRequest(r *Request, api string, args []string, isAsync bool) (map[str | |||
| } | |||
| } | |||
| params.Add("response", "json") | |||
| params.Add("signatureversion", "3") | |||
| params.Add(expiresKey, time.Now().UTC().Add(15 * time.Minute).Format(time.RFC3339)) | |||
config/config.go
Outdated
| @@ -282,6 +284,9 @@ func saveConfig(cfg *Config) *Config { | |||
| core.AutoComplete = true | |||
| core.Output = JSON | |||
| } | |||
| if conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { | |||
There was a problem hiding this comment.
| if conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { | |
| if !conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { | |
| core.PostRequest = false |
There was a problem hiding this comment.
@kevin-lii , @sureshanaparti sugested **_!_**conf.Section(ini.DEFAITL_SECTION).HasKey(“postrequest”), you have without the negation. Are you sure this is what you intend to do?
There was a problem hiding this comment.
if !conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { - cond. should be this one, right @kevin-lii ?
| @@ -284,7 +284,7 @@ func saveConfig(cfg *Config) *Config { | |||
| core.AutoComplete = true | |||
| core.Output = JSON | |||
| } | |||
| if conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { | |||
| if !conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { { | |||
There was a problem hiding this comment.
| if !conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { { | |
| if !conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { |
There was a problem hiding this comment.
@kevin-lii check this, build fails
| @@ -282,6 +284,9 @@ func saveConfig(cfg *Config) *Config { | |||
| core.AutoComplete = true | |||
| core.Output = JSON | |||
| } | |||
| if !conf.Section(ini.DEFAULT_SECTION).HasKey("postrequest") { { | |||
| core.PostRequest = false | |||
| } | |||
There was a problem hiding this comment.
@kevin-lii seems some confusion here, core here is not reflected from the defaultCoreConfig(), and core.PostRequest is false by default. possible to check the conf section has postrequest key and it's value is true, to set core.PostRequest = true? Are you able to verify the GET & POST calls with this change?
Description
Currently, CMK only allows for POST requests and this is a security concern since GET requests may leak the values of the query parameters.
Types of changes
[] Breaking change (fix or feature that would cause existing functionality to change)
[] New feature (non-breaking change which adds functionality)
[] Bug fix (non-breaking change which fixes an issue)
[] Enhancement (improves an existing feature and functionality)
[] Cleanup (Code refactoring and cleanup, that may add test cases)
[] build/CI
[] test (unit or integration test code)
[X] Feature/Enhancement Scale
[] Major
[X] Minor
How Has This Been Tested?
This was tested by manually building CMK and using a proxy to confirm that POST requests are being sent by CMK when the configuration value is set.