mgmt: add back serviceip in ManagementServerResponse

[weizhouapache]

Description

The PR #9773 changed the serviceip to ipaddress in the API response, which broke backward compatibility.

Although a test failure has been fixed in #10501 , I think it would be better to add it back.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 16.14%. Comparing base (5444261) to head (dfd1c46).
Report is 2 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...udstack/api/response/ManagementServerResponse.java	0.00%	6 Missing ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10891   +/-   ##
=========================================
  Coverage     16.13%   16.14%           
- Complexity    13239    13241    +2     
=========================================
  Files          5656     5656           
  Lines        497579   497586    +7     
  Branches      60333    60333           
=========================================
+ Hits          80297    80312   +15     
+ Misses       408333   408324    -9     
- Partials       8949     8950    +1     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	16.99% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[abh1sar]

LGTM

[rohityadavcloud]

LGTM - since this fixes API regression, we should consider this as critical for 4.20.1

[rohityadavcloud]

@weizhouapache can you also look at failing github action smoketests?
@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13454

[weizhouapache]

@weizhouapache can you also look at failing github action smoketests?

thanks @rohityadavcloud

the remaining test failures are addressed by #10875

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[DaanHoogland]

@weizhouapache , can we somehow mark it as deprecated? (ltgm, btw)

[weizhouapache]

@weizhouapache , can we somehow mark it as deprecated? (ltgm, btw)

@DaanHoogland
yes, I will add Deprecated annotation, but I am not sure if it makes differences.

[DaanHoogland]

@weizhouapache , can we somehow mark it as deprecated? (ltgm, btw)

@DaanHoogland yes, I will add Deprecated annotation, but I am not sure if it makes differences.

I think it would be good to add it to the description that using ipaddress instead is advised.

[weizhouapache]

@weizhouapache , can we somehow mark it as deprecated? (ltgm, btw)

@DaanHoogland yes, I will add Deprecated annotation, but I am not sure if it makes differences.

I think it would be good to add it to the description that using ipaddress instead is advised.

that's already added. @DaanHoogland

I added Deprecated annotation as well

[DaanHoogland]

that's already added. @DaanHoogland

sorry, reviewed from the wild (not at desk)

I added Deprecated annotation as well

great, I don’t think we can do better.

[blueorangutan]

[SF] Trillian test result (tid-13359)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60065 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10891-t13359-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File