[UI] Fix display of disk size and IOPS fields in the scale VM form

[bernardodemarco]

Description

When scaling VMs, it is possible to change the disk offering for the VMs' ROOT disk if the global setting allow.diskoffering.change.during.scale.vm is true. To change the disk offering, the new selected compute offering for the VM must have the disk offering attached to it.

However, for custom disk offerings (custom size and/or IOPS), it is not possible to currently define the values of the size and IOPS in the UI form:

Thus, this PR proposes to fix the scale VM UI form to display the custom disk size and IOPS fields.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

• Before:

• After:

How Has This Been Tested?

• Verified that it is possible to define a custom disk size and IOPS for custom disk offerings.
• Verified that the fields are not displayed for non-custom disk offerings.

[bernardodemarco]

@blueorangutan ui

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.18%. Comparing base (d161dc7) to head (5d871c1).
⚠️ Report is 4 commits behind head on 4.19.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #11553   +/-   ##
=========================================
  Coverage     15.18%   15.18%           
- Complexity    11368    11370    +2     
=========================================
  Files          5415     5415           
  Lines        476073   476073           
  Branches      58125    58125           
=========================================
+ Hits          72279    72301   +22     
+ Misses       395706   395680   -26     
- Partials       8088     8092    +4     

Flag	Coverage Δ
uitests	4.28% <ø> (ø)
unittests	15.91% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bernardodemarco]

@blueorangutan ui

[blueorangutan]

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11553 (QA-JID-735)

[DaanHoogland]

clgtm and verified in qa

[shwstppr]

coed lgtm

[weizhouapache]

Merging based on approvals and manual verification by @DaanHoogland