Skip to content

Conversation

sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Sep 3, 2025

Description

This PR updates backup framework enabled config to global scope (from the existing zone scope).

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.17%. Comparing base (9349b69) to head (b0b037f).
⚠️ Report is 2 commits behind head on 4.20.

Files with missing lines Patch % Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #11567      +/-   ##
============================================
- Coverage     16.17%   16.17%   -0.01%     
- Complexity    13294    13296       +2     
============================================
  Files          5656     5656              
  Lines        498082   498082              
  Branches      60415    60414       -1     
============================================
- Hits          80569    80568       -1     
  Misses       408551   408551              
- Partials       8962     8963       +1     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.02% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@abh1sar abh1sar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this at line 983. Otherwise backup apis won't show if backup framework is enabled at zone but disabled globally.

        if (!BackupFrameworkEnabled.value()) {
            return cmdList;
        }

@sureshanaparti sureshanaparti changed the title Check backup framework enabled config in zone scope first (before checking in global scope) [WIP] Check backup framework enabled config in zone scope first (before checking in global scope) Sep 4, 2025
@sureshanaparti sureshanaparti force-pushed the check-backup-framework-disable-in-zone branch from 2f0ee6d to b0b037f Compare September 9, 2025 10:35
@sureshanaparti sureshanaparti changed the title [WIP] Check backup framework enabled config in zone scope first (before checking in global scope) Update backup framework enabled config to global scope Sep 9, 2025
@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves the backup framework enabled configuration from zone-scoped to global-scoped, simplifying the backup management by removing per-zone enablement checks. The change affects how the backup framework determines if it's enabled, removing the need to check individual zones.

Key Changes

  • Removed zone-specific backup framework configuration support
  • Simplified backup enablement logic to use global configuration only
  • Updated error messages to reflect global scope

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
api/src/main/java/org/apache/cloudstack/backup/BackupManager.java Removes zone scope from backup framework configuration key
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java Updates backup enablement checks to use global configuration and removes zone-specific logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 14918

@sureshanaparti sureshanaparti changed the title Update backup framework enabled config to global scope [WIP] Update backup framework enabled config to global scope Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants