UI: Update domain level configuration #11571
Conversation
Pearl1594
requested review from
kiranchavala,
DaanHoogland,
harikrishna-patnala and
weizhouapache
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11571 +/- ##
============================================
- Coverage 17.36% 17.36% -0.01%
Complexity 15237 15237
============================================
Files 5888 5888
Lines 525741 525746 +5
Branches 64164 64167 +3
============================================
- Hits 91274 91273 -1
- Misses 424167 424172 +5
- Partials 10300 10301 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
| @@ -280,6 +295,9 @@ export default { | |||
| name: configrecord.name, | |||
| value: newValue | |||
| } | |||
| if (this.scopeKey === 'domainid' && !params[this.scopeKey]) { | |||
There was a problem hiding this comment.
do we need the this.scopeKey === 'domainid' check? Can it be
| if (this.scopeKey === 'domainid' && !params[this.scopeKey]) { | |
| if (this.scopeKey && !params[this.scopeKey]) { |
There was a problem hiding this comment.
I specifically added domainid, because it's taken care of for other cases.
| @@ -254,6 +258,17 @@ export default { | |||
| this.setConfigData() | |||
| }, | |||
| watch: { | |||
| loading (newVal, oldVal) { | |||
There was a problem hiding this comment.
Is loading value for the element set somewhere in the code?
Similarly for property configDisable, though unrelated to the PR
Description
This PR fixes #11570
Following issues were fixed:
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?