HAproxy based load balancer Customisation #7484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7484 +/- ##
============================================
- Coverage 19.87% 13.81% -6.06%
+ Complexity 19052 10440 -8612
============================================
Files 4966 3094 -1872
Lines 336442 291065 -45377
Branches 48347 47361 -986
============================================
- Hits 66869 40221 -26648
+ Misses 259830 245653 -14177
+ Partials 9743 5191 -4552
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4070 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CharlesQueiroz
force-pushed
the
lbconfigs
branch
2 times, most recently
from
852de1b to
28fda8f
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
Hi @ustcweizhou, I recently opened this pull request with HAProxy config changes. It would be great to have your opinion on my changes. I have reviewed the code and run some tests, but I'd like your opinion to ensure that the code follows best practices and is scalable for future implementations. I'd appreciate you looking at my pull request and giving me some suggestions or pointing out any problems you find. It would be essential to get your opinion and expertise. Thank you very much in advance for your help and time. |
Hi @CharlesQueiroz cc @rohityadavcloud @DaanHoogland @shwstppr |
|
@blueorangutan package |
|
@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6154 |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
CharlesQueiroz
force-pushed
the
lbconfigs
branch
3 times, most recently
from
47a3fa4 to
ea7d322
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7060 |
|
@blueorangutan test |
|
@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-7692)
|
|
@blueorangutan package |
|
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7150 |
|
@blueorangutan test |
|
@CharlesQueiroz can you look at the github action failures? |
|
@CharlesQueiroz (cc @weizhouapache ) will this be done in time for 4.19 or should we postpone? |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@weizhouapache @DaanHoogland The person that opened this third incarnation of this PR no longer works at Leaseweb, but the features it offers really have added value. Is there any way we can breathe life into this? (I'm not much of a Java programmer myself) |
@hrak this may involve some skills, certainly involves java, but also python, VueJS and networking. However, it may also be a matter of a simple conflict resolution, in which case it will still need extensive testing. I.E. investments needed. Can you discuss internally what you can bring to the table? (I will do as well, but can only promise that it will not be soon) |
|
Hey Guys, ive been following this topic and i think this is the 3rd incarnation of this feature? This features really important to us because we have customers whos service use very long lived TCP connections, and the default 50second timeout is making the platform unusable in most cases. Is there any way we can temporarily change the Timeout Client/Server setting? Eg. Change HA Proxy Setting directly via Virtual Router? Will that work? |
|
@blueorangutan test |
|
@borisstoyanov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
@hrak since this PR was created from Leaseweb repo but none of us (except you) have write permission to the repo, therefore no way to update the PR if needed. Can we fork the branch , push to apache/cloudstack repo and then create a new PR, so that the apache cloudstack committers can update it ? |
@weizhouapache Yes feel free, that is fine. I briefly tried syncing with main but got a bunch of conflicts, and i am not familiar enough with the codebase here to dive into that. Thank you for your efforts! |
|
[SF] Trillian test result (tid-11311)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new feature for load balancers based on haproxy.
FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/VR+haproxy+customization+in+CloudStack
Fixes #3789
This commit was based on this:
#4141 and #5799
It supports (or will support)
Basic proxy configurations:
haproxy statistics uri, auth, enable/disable
global maxconn and maxpipes
Basic configurations on rule
timeout connection, client ,server globally and per rule
http, httpalive per rule
maxconn, fullconn per rule
maxconn, minconn, maxqueue per server in rule
advanced features
transparent load balancer
SSL offloading
http2 support
Variable SSL configurations
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
Adding networks level haproxy configs
Adding load balancer level configs
Adding SSL Certificate