Refactor configuration SystemVMDefaultHypervisor #8934
Conversation
GaOrtiga
changed the title
| ConfigKey<String> SystemVMDefaultHypervisor = new ConfigKey<String>(String.class, | ||
| "system.vm.default.hypervisor", "Advanced", "Any", "Hypervisor type used to create System VMs. Valid values are: XenServer, KVM, VMware, Hyperv, VirtualBox, " + | ||
| "Parralels, BareMetal, Ovm, LXC, Any", true, ConfigKey.Scope.Global, null, null, null, null, null, ConfigKey.Kind.Select, "XenServer, KVM, VMware, Hyperv, " + | ||
| "VirtualBox, Parralels, BareMetal, Ovm, LXC, Any"); |
There was a problem hiding this comment.
as this is moved to configkey, can change the scope to zone, and handle zone detail "defaultSystemVMHypervisorType" in upgrade?
There was a problem hiding this comment.
@sureshanaparti I agree with changing the scope to zone, however, can you further explain what you mean by handling "defaultSystemVMHypervisorType" in upgrade?
Wouldn't changing the scope to zone and fetching the value of the config for the specific zone be sufficient to guarantee the expected behaviour?
There was a problem hiding this comment.
@GaOrtiga
should the default value be "None" ?
There was a problem hiding this comment.
@weizhouapache
Yes, the default must be "None" to keep the current behaviour. However, since this configuration is only setting a default, "None" and "Any" have the same behaviour.
There was a problem hiding this comment.
@GaOrtiga
I quickly checked the code. it looks like the default value is NULL which is same as "None"
I suggest we keep it empty or None.
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9306 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-9929)
|
|
@blueorangutan package |
|
@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8934 +/- ##
===========================================
Coverage 15.81% 15.81%
Complexity 12554 12554
===========================================
Files 5629 5629
Lines 492028 492026 -2
Branches 62750 61393 -1357
===========================================
Hits 77813 77813
+ Misses 405892 405890 -2
Partials 8323 8323
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9908 |
|
@blueorangutan package |
|
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10640 |
GaOrtiga
force-pushed
the
Refactor_config_SystemVMDefaultHypervisor
branch
from
9d226fe
to
13becce
Compare
|
@blueorangutan package |
|
@GaOrtiga a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11102 |
|
@GaOrtiga @BryanMLima what is the status of this PR? |
It is ready for review. |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11154 |
|
Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 11158 |
Description
The configuration
SystemVMDefaultHypervisoris not dynamic, it is necessary to restart the management server after each alteration to its value. Besides, its input is a String, which forces the user to type in the name of the chosen hypervisor, being subject to typos.This configuration was refactored, allowing its value to be altered in runtime; besides, its input was converted to a select, in order to facilitate the process of choosing the new value.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
How Has This Been Tested?
I changed the values of the configurations and verified that the default hypervisors for new system vms changed accordingly