Shared Filesystem as a First Class Feature #9208

abh1sar · 2024-06-11T03:47:17Z

Description

This PR implements Storage filesystem as a first class feature.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Storage+Filesystem+as+a+First+Class+Feature

Documentation PR: apache/cloudstack-documentation#420

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

…FsVmFileShareProvider

…r minor changes

github-actions · 2024-06-11T05:33:06Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

… and remove

codecov · 2024-06-21T19:31:06Z

Codecov Report

Attention: Patch coverage is 38.06986% with 1046 lines in your changes missing coverage. Please review.

Project coverage is 15.64%. Comparing base (72d0546) to head (c5214ac).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...tack/storage/sharedfs/query/vo/SharedFSJoinVO.java	1.70%	114 Missing and 1 partial ⚠️
...mmand/user/storage/sharedfs/CreateSharedFSCmd.java	0.00%	108 Missing ⚠️
...oudstack/storage/sharedfs/SharedFSServiceImpl.java	73.38%	76 Missing and 31 partials ⚠️
...oudstack/storage/sharedfs/dao/SharedFSDaoImpl.java	0.00%	56 Missing ⚠️
...age/sharedfs/ChangeSharedFSServiceOfferingCmd.java	0.00%	51 Missing ⚠️
...mand/user/storage/sharedfs/RestartSharedFSCmd.java	0.00%	51 Missing ⚠️
...ache/cloudstack/api/response/SharedFSResponse.java	59.84%	49 Missing and 2 partials ⚠️
...apache/cloudstack/storage/sharedfs/SharedFSVO.java	40.00%	51 Missing ⚠️
...ommand/user/storage/sharedfs/StartSharedFSCmd.java	0.00%	48 Missing ⚠️
...sharedfs/lifecycle/StorageVmSharedFSLifeCycle.java	68.99%	28 Missing and 12 partials ⚠️
... and 30 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9208      +/-   ##
============================================
+ Coverage     15.57%   15.64%   +0.06%     
- Complexity    12056    12110      +54     
============================================
  Files          5506     5535      +29     
  Lines        482997   485033    +2036     
  Branches      59483    62628    +3145     
============================================
+ Hits          75236    75887     +651     
- Misses       399450   400773    +1323     
- Partials       8311     8373      +62

Flag	Coverage Δ
uitests	`4.12% <ø> (-0.05%)`	⬇️
unittests	`16.44% <38.06%> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

abh1sar · 2024-09-05T07:09:30Z

@blueorangutan package

blueorangutan · 2024-09-05T07:10:03Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-05T08:32:25Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10985

DaanHoogland · 2024-09-05T08:37:57Z

@blueorangutan test matrix

blueorangutan · 2024-09-05T08:40:04Z

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

blueorangutan · 2024-09-05T08:42:21Z

[SF] Trillian Build Failed (tid-11358)

borisstoyanov

LGTM, the test failures does not seem related.

github-actions · 2024-09-05T09:13:18Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2024-09-05T09:55:21Z

@blueorangutan package

blueorangutan · 2024-09-05T09:56:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

github-actions · 2024-09-05T10:57:32Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

blueorangutan · 2024-09-05T11:01:36Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10994

rohityadavcloud · 2024-09-05T11:32:36Z

@blueorangutan test

blueorangutan · 2024-09-05T11:34:04Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

rohityadavcloud · 2024-09-05T11:51:56Z

Merging this based on previous test runs and code review, will do another round of review after merging this.

Pearl1594 · 2024-09-05T21:54:39Z

engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql

+    INDEX `i_shared_filesystem__domain_id`(`domain_id`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
+DROP VIEW IF EXISTS `cloud`.`user_vm_view`;


Not sure if we need this here as well as it's already added in the respective view file: https://github.com/apache/cloudstack/pull/9208/files#diff-a5be1b062185fbc803c3f9a03ab8aab590b475a8cafbd46760607a7a071ea606R28

Yes, this is not required. Will remove it in a separate PR.

blueorangutan · 2024-09-06T03:01:53Z

[SF] Trillian test result (tid-11372)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 54653 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9208-t11372-kvm-ubuntu22.zip
Smoke tests completed. 140 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2024-09-06T07:05:43Z

[SF] Trillian test result (tid-11373)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 67723 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9208-t11373-kvm-ol8.zip
Smoke tests completed. 131 look OK, 3 have errors, 6 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_mount_shared_fs	`Failure`	85.08	test_sharedfs_lifecycle.py
test_resize_shared_fs	`Error`	0.24	test_sharedfs_lifecycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	404.02	test_vm_life_cycle.py
test_10_attachAndDetach_iso	`Failure`	678.04	test_vm_life_cycle.py
test_02_redundant_VPC_default_routes	`Failure`	1486.14	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	474.30	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Failure`	608.73	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	608.75	test_vpc_redundant.py
all_test_vpc_router_nics	`Skipped`	---	test_vpc_router_nics.py
all_test_vpc_vpn	`Skipped`	---	test_vpc_vpn.py
all_test_webhook_delivery	`Skipped`	---	test_webhook_delivery.py
all_test_webhook_lifecycle	`Skipped`	---	test_webhook_lifecycle.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

blueorangutan · 2024-09-06T07:54:02Z

[SF] Trillian test result (tid-11371)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server a9
Total time taken: 72661 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9208-t11371-xcpng82.zip
Smoke tests completed. 134 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_condensed_drs_algorithm	`Failure`	175.25	test_cluster_drs.py
test_02_balanced_drs_algorithm	`Failure`	184.10	test_cluster_drs.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	`Error`	7.49	test_network.py
test_01_non_strict_host_anti_affinity	`Error`	213.68	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	107.92	test_nonstrict_affinity_group.py
test_02_create_volume	`Error`	2.19	test_resource_names.py
test_05_scale_vm_dont_allow_disk_offering_change	`Failure`	65.30	test_scale_vm.py
test_01_volume_usage	`Error`	97.91	test_usage.py

) This PR implements Storage filesystem as a first class feature. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Storage+Filesystem+as+a+First+Class+Feature Documentation PR: apache/cloudstack-documentation#420 Co-authored-by: Wei Zhou <[email protected]>

blueorangutan · 2024-09-06T12:48:35Z

[SF] Trillian test result (tid-11370)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 89854 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9208-t11370-vmware-70u3.zip
Smoke tests completed. 123 look OK, 4 have errors, 13 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deployVMInSharedNetwork	`Failure`	3609.01	test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:teardown	`Error`	3610.25	test_network.py
test_create_pvlan_network	`Error`	0.09	test_pvlan.py
test_02_restore_vm_with_disk_offering	`Error`	61.17	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	`Error`	54.94	test_restore_vm.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup	`Error`	0.00	test_snapshots.py
all_test_ssvm	`Skipped`	---	test_ssvm.py
all_test_staticroles	`Skipped`	---	test_staticroles.py
all_test_storage_policy	`Skipped`	---	test_storage_policy.py
all_test_templates	`Skipped`	---	test_templates.py
all_test_update_security_group	`Skipped`	---	test_update_security_group.py
all_test_usage_events	`Skipped`	---	test_usage_events.py
all_test_usage	`Skipped`	---	test_usage.py
all_test_vm_autoscaling	`Skipped`	---	test_vm_autoscaling.py
all_test_vm_deployment_planner	`Skipped`	---	test_vm_deployment_planner.py
all_test_vm_life_cycle	`Skipped`	---	test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import	`Skipped`	---	test_vm_lifecycle_unmanage_import.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

abh1sar added 10 commits June 1, 2024 11:21

File share : db schema

6233ebd

File Share : FileShare interface with fsm and constants

bbbbb69

File share : crud apis, vo and dao skeleton.

af3d873

File Share : ServiceImpl class and framework-plugin structure

dc916f8

File Share : Skeleton code for SimulatorFileShareProvider and Storage…

948ee45

…FsVmFileShareProvider

File Share : Dao spring context, added created and removed to VO

d6aac5c

File Share : minor changes to FileShareDao

5bff62e

File Share : Added lifecycle class, file share provider map etc

43ccf1e

File Share : added emtpy constructor to FileShareVO

96375f3

File Share : Added schema, vo and dao for storagefsvm table plus othe…

0f52310

…r minor changes

boring-cyborg bot added component:api component:build component:storage labels Jun 11, 2024

github-actions bot added the status:has-conflicts label Jun 11, 2024

abh1sar added 2 commits June 22, 2024 00:31

File Share : Api, response and service layer changes for create, list…

3a692b9

… and remove

Merge remote-tracking branch 'upstream/main' into fsp_synced

e21c457

github-actions bot removed the status:has-conflicts label Jun 21, 2024

File Share : minor fix to gen_toc

a156214

abh1sar requested a review from weizhouapache June 21, 2024 19:36

abh1sar self-assigned this Jun 21, 2024

abh1sar added 3 commits June 23, 2024 12:20

File Share : api, service layer implementations

4bd8283

File Share : minor - import remove in StorageFsVMFileShareLifeCycle

ebbc1e8

UI, fileshare response, update api

6d85670

boring-cyborg bot added component:networking component:orchestration labels Jun 29, 2024

abh1sar added 3 commits June 29, 2024 10:57

Merge remote-tracking branch 'upstream/main' into fsp

f3fd82c

fix StorageFsVmFileShareLifeCycle impl

204aaa1

State and event changes

fcb39c2

Merge remote-tracking branch 'upstream/main' into fs

1cf6c90

borisstoyanov approved these changes Sep 5, 2024

View reviewed changes

github-actions bot added the status:has-conflicts label Sep 5, 2024

Merge remote-tracking branch 'upstream/main' into fs

c5214ac

github-actions bot removed the status:has-conflicts label Sep 5, 2024

github-actions bot added the status:has-conflicts label Sep 5, 2024

github-actions bot removed the status:has-conflicts label Sep 5, 2024

rohityadavcloud merged commit 605534b into apache:main Sep 5, 2024
26 checks passed

Pearl1594 reviewed Sep 5, 2024

View reviewed changes

abh1sar deleted the filesharepoc branch September 6, 2024 05:59

abh1sar changed the title ~~Storage Filesystem as a First Class Feature~~ Shared Filesystem as a First Class Feature Sep 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shared Filesystem as a First Class Feature #9208

Shared Filesystem as a First Class Feature #9208

abh1sar commented Jun 11, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024

codecov bot commented Jun 21, 2024 •

edited

Loading

abh1sar commented Sep 5, 2024

blueorangutan commented Sep 5, 2024

blueorangutan commented Sep 5, 2024

DaanHoogland commented Sep 5, 2024

blueorangutan commented Sep 5, 2024

blueorangutan commented Sep 5, 2024

borisstoyanov left a comment

github-actions bot commented Sep 5, 2024

DaanHoogland commented Sep 5, 2024

blueorangutan commented Sep 5, 2024

github-actions bot commented Sep 5, 2024

blueorangutan commented Sep 5, 2024

rohityadavcloud commented Sep 5, 2024

blueorangutan commented Sep 5, 2024

rohityadavcloud commented Sep 5, 2024

Pearl1594 Sep 5, 2024

abh1sar Sep 6, 2024

blueorangutan commented Sep 6, 2024

blueorangutan commented Sep 6, 2024

blueorangutan commented Sep 6, 2024

blueorangutan commented Sep 6, 2024

Shared Filesystem as a First Class Feature #9208

Shared Filesystem as a First Class Feature #9208

Conversation

abh1sar commented Jun 11, 2024 • edited Loading

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

github-actions bot commented Jun 11, 2024

codecov bot commented Jun 21, 2024 • edited Loading

Codecov Report

abh1sar commented Sep 5, 2024

blueorangutan commented Sep 5, 2024

blueorangutan commented Sep 5, 2024

DaanHoogland commented Sep 5, 2024

blueorangutan commented Sep 5, 2024

blueorangutan commented Sep 5, 2024

borisstoyanov left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 5, 2024

DaanHoogland commented Sep 5, 2024

blueorangutan commented Sep 5, 2024

github-actions bot commented Sep 5, 2024

blueorangutan commented Sep 5, 2024

rohityadavcloud commented Sep 5, 2024

blueorangutan commented Sep 5, 2024

rohityadavcloud commented Sep 5, 2024

Pearl1594 Sep 5, 2024

Choose a reason for hiding this comment

abh1sar Sep 6, 2024

Choose a reason for hiding this comment

blueorangutan commented Sep 6, 2024

blueorangutan commented Sep 6, 2024

blueorangutan commented Sep 6, 2024

blueorangutan commented Sep 6, 2024

abh1sar commented Jun 11, 2024 •

edited

Loading

codecov bot commented Jun 21, 2024 •

edited

Loading