Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Show applied search filters #9520

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Aug 13, 2024

Description

This PR adds the feature to show applied search filters in the UI.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

image

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.58%. Comparing base (b429e84) to head (b0ea771).
Report is 31 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9520      +/-   ##
============================================
+ Coverage     15.54%   15.58%   +0.03%     
- Complexity    11998    12039      +41     
============================================
  Files          5496     5502       +6     
  Lines        481522   482436     +914     
  Branches      60782    60585     -197     
============================================
+ Hits          74858    75178     +320     
- Misses       398376   398929     +553     
- Partials       8288     8329      +41     
Flag Coverage Δ
uitests 4.28% <ø> (+0.10%) ⬆️
unittests 16.36% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-419)

@vishesh92 vishesh92 force-pushed the ui-show-search-filters branch 2 times, most recently from 47e4a82 to 00985d0 Compare August 13, 2024 12:10
@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-420)

@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-421)

@sureshanaparti
Copy link
Contributor

sureshanaparti commented Aug 16, 2024

Search message not in sync with filters =>

diff-msg-shown

UUIDs loaded instead of name for Zone, Group in filter view (on close & re-open) - Check if selected names can be populated as before =>

uuid-loaded-on-filter-view uuid-loaded-on-filter-view-zone-and-group

@vishesh92 vishesh92 force-pushed the ui-show-search-filters branch 2 times, most recently from 6975bd9 to a2a3260 Compare August 27, 2024 08:26
@vishesh92
Copy link
Member Author

@blueorangutan ui

@apache apache deleted a comment from blueorangutan Aug 27, 2024
@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9520 (QA-JID-434)

@apache apache deleted a comment from blueorangutan Aug 28, 2024
@apache apache deleted a comment from blueorangutan Aug 28, 2024
@apache apache deleted a comment from blueorangutan Aug 28, 2024
@apache apache deleted a comment from blueorangutan Aug 28, 2024
@apache apache deleted a comment from blueorangutan Aug 28, 2024
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm tested in qa

@DaanHoogland
Copy link
Contributor

@sureshanaparti , is your problem solved?

@sureshanaparti
Copy link
Contributor

@sureshanaparti , is your problem solved?

@sureshanaparti , is your problem solved?

yes, the response objects are different. so, there is separate implementation for listing & validation. is that correct @vishesh92

@vishesh92 vishesh92 added this to the 4.20.1.0 milestone Sep 16, 2024
@vishesh92
Copy link
Member Author

Had a discussion with @rohityadavcloud offline. He had some remarks about the UI and we agreed revisit it later. Moved this 4.20.1.0 milestone for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants