-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Show applied search filters #9520
base: main
Are you sure you want to change the base?
Conversation
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9520 +/- ##
============================================
+ Coverage 15.54% 15.58% +0.03%
- Complexity 11998 12039 +41
============================================
Files 5496 5502 +6
Lines 481522 482436 +914
Branches 60782 60585 -197
============================================
+ Hits 74858 75178 +320
- Misses 398376 398929 +553
- Partials 8288 8329 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
UI build: ✔️ |
47e4a82
to
00985d0
Compare
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
00985d0
to
21ca320
Compare
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
267d78b
to
1655b61
Compare
6975bd9
to
a2a3260
Compare
a2a3260
to
b0ea771
Compare
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm tested in qa
@sureshanaparti , is your problem solved? |
yes, the response objects are different. so, there is separate implementation for listing & validation. is that correct @vishesh92 |
Had a discussion with @rohityadavcloud offline. He had some remarks about the UI and we agreed revisit it later. Moved this 4.20.1.0 milestone for now. |
Description
This PR adds the feature to show applied search filters in the UI.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?