-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VMware] Consider CD/DVD drive when calculating next free unit number for volume attachment over IDE controller #9644
base: 4.19
Are you sure you want to change the base?
Conversation
@blueorangutan package |
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9644 +/- ##
===========================================
Coverage 15.08% 15.08%
- Complexity 11185 11193 +8
===========================================
Files 5406 5406
Lines 473123 473215 +92
Branches 58163 60800 +2637
===========================================
+ Hits 71371 71390 +19
- Misses 393810 393877 +67
- Partials 7942 7948 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11021 |
@blueorangutan test ol8 vmware-70u3 |
@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
Outdated
Show resolved
Hide resolved
[SF] Trillian test result (tid-11398)
|
…alMachineMO.java Co-authored-by: dahn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLGTM
Description
When attaching a volume to an instance, CloudStack calculates the next free unit number of the disk controller that should be associated with the volume. However, for IDE disk controllers, CD/DVD drives associated with the controller are not taken into consideration when calculating the next available unit number. Due to this, an error happens in some situations when trying to attach a volume to an instance over IDE controllers because CloudStack tries to associate the volume to an unit number that is already being used.
The generic method of reproducing this problem is:
dataDiskController
toide
This PR fixes the issue by making the code also consider CD/DVD drives. Tests will be added in another PR alongside an extension for the disk controllers that I'm currently working on, as it will require me to modify this code again.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
rootDiskController
anddataDiskController
set toide
, with only a root disk