Update of the schema 41910to42000.sql for compatibility with MariaDB version 10.3.38.

[LayonRibeiro]

Description

This PR changes two column renames in schema-41910to42000.sql. Using MariaDB version 10.3.38-MariaDB, some lines are not applying the expected changes to the column names in the tables. This issue results in errors during the version transition process.

The modifications made to the schema-41910to42000.sql ensure that changes to the tables are applied correctly. With these fixes, the transition between versions should proceed successfully, without errors.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

How Has This Been Tested?

I made the mentioned changes, and the transition between versions went as expected.

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.81%. Comparing base (1d4700a) to head (0054119).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##               main    #9680    +/-   ##
==========================================
  Coverage     15.81%   15.81%            
  Complexity    12554    12554            
==========================================
  Files          5629     5629            
  Lines        492029   492029            
  Branches      62293    62841   +548     
==========================================
+ Hits          77811    77813     +2     
+ Misses       405894   405893     -1     
+ Partials       8324     8323     -1     

Flag	Coverage Δ
uitests	4.48% <ø> (ø)
unittests	16.60% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11111

[DaanHoogland]

clgtm

[DaanHoogland]

@blueorangutan LLtest

[blueorangutan]

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[rohityadavcloud]

LGTM - didn't test it though

[weizhouapache]

code lgtm

@JoaoJandre @DaanHoogland
If the issue exists with mariadb 10 and is fixed by this PR, we should merge this.

[weizhouapache]

@LayonRibeiro
can you update the title with a short summary of the issue ?

[JoaoJandre]

LGTM. Tested in a local lab:

• With MariaDB 10.11.2, tried to update from 4.19 to 4.20. Before the changes, the script failed to update the columns.
• After the changes, the columns were renamed successfully.

[DaanHoogland]

@JoaoJandre , for people using mariadb 10 this is actually a blocker. I don't know if mariadb10 is well supported otherwise, but I think we should include this.

[JoaoJandre]

@JoaoJandre , for people using mariadb 10 this is actually a blocker. I don't know if mariadb10 is well supported otherwise, but I think we should include this.

Yes we are including this for sure. I'm just waiting for the CI results and we can merge this.

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[rohityadavcloud]

Do we need explicit testing if Github Actions smoketests have passed? (that I reckon runs against MySQL 8.x)? @JoaoJandre @DaanHoogland

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11130

[DaanHoogland]

Do we need explicit testing if Github Actions smoketests have passed? (that I reckon runs against MySQL 8.x)? @JoaoJandre @DaanHoogland

I think we can merge. cc @weizhouapache

[JoaoJandre]

Do we need explicit testing if Github Actions smoketests have passed? (that I reckon runs against MySQL 8.x)? @JoaoJandre @DaanHoogland

I think we can merge. cc @weizhouapache

@DaanHoogland shouldn't we wait for the CI results?

[DaanHoogland]

Do we need explicit testing if Github Actions smoketests have passed? (that I reckon runs against MySQL 8.x)? @JoaoJandre @DaanHoogland

I think we can merge. cc @weizhouapache

@DaanHoogland shouldn't we wait for the CI results?

It will not give us more information than the GitHub actions in this case, as @rohityadavcloud implies.

[JoaoJandre]

Do we need explicit testing if Github Actions smoketests have passed? (that I reckon runs against MySQL 8.x)? @JoaoJandre @DaanHoogland

I think we can merge. cc @weizhouapache

@DaanHoogland shouldn't we wait for the CI results?

It will not give us more information than the GitHub actions in this case, as @rohityadavcloud implies.

Sorry, I missed that message 😅