Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routed mode: minor improvements #9697

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

weizhouapache
Copy link
Member

Description

This PR

  • adds a global setting to enable/disable the Static/Dynamic routing feature
  • add some unit tests

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 62.74510% with 19 lines in your changes missing coverage. Please review.

Project coverage is 15.97%. Comparing base (94a47ac) to head (b5360ae).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...g/apache/cloudstack/api/response/ZoneResponse.java 0.00% 7 Missing ⚠️
...ache/cloudstack/network/RoutedIpv4ManagerImpl.java 80.00% 6 Missing ⚠️
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java 40.00% 1 Missing and 2 partials ⚠️
...ain/java/com/cloud/network/NetworkServiceImpl.java 71.42% 1 Missing and 1 partial ⚠️
...com/cloud/api/query/dao/DataCenterJoinDaoImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9697      +/-   ##
============================================
+ Coverage     15.81%   15.97%   +0.15%     
- Complexity    12554    12702     +148     
============================================
  Files          5629     5629              
  Lines        492015   492045      +30     
  Branches      61922    59879    -2043     
============================================
+ Hits          77821    78586     +765     
+ Misses       405873   404988     -885     
- Partials       8321     8471     +150     
Flag Coverage Δ
uitests 4.48% <ø> (-0.01%) ⬇️
unittests 16.77% <62.74%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11137

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-11515)

@weizhouapache weizhouapache marked this pull request as ready for review September 19, 2024 06:34
@blueorangutan
Copy link

[SF] Trillian test result (tid-11516)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51439 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9697-t11516-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants