Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: enable project menu on mobile devices #9700

Merged

Conversation

weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Sep 18, 2024

Description

This PR shows project menu on mobile devices

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.11%. Comparing base (a8ab47b) to head (298dbb3).
Report is 6 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff             @@
##               4.19    #9700     +/-   ##
===========================================
  Coverage     15.11%   15.11%             
+ Complexity    11189    11187      -2     
===========================================
  Files          5406     5406             
  Lines        473215   473215             
  Branches      61384    59430   -1954     
===========================================
+ Hits          71516    71528     +12     
+ Misses       393891   393883      -8     
+ Partials       7808     7804      -4     
Flag Coverage Δ
uitests 4.76% <ø> (ø)
unittests 15.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Contributor

@weizhouapache have you tested this/ is it draft? I wonder why this was put in place. Is the reason for that gone?

@weizhouapache
Copy link
Member Author

@weizhouapache have you tested this/ is it draft? I wonder why this was put in place. Is the reason for that gone?

@DaanHoogland
to be frank, I have no idea.
it was introduced in a very early commit 63e6173 by @rohityadavcloud

I used Chrome for testing

  • an env without this PR

image

  • an env with this change

image

@weizhouapache weizhouapache changed the title UI: enable project menu on mobile UI: enable project menu on mobile devices Sep 18, 2024
@weizhouapache
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@DaanHoogland
Copy link
Contributor

ok, will test on ff

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9700 (QA-JID-451)

@DaanHoogland
Copy link
Contributor

ok, will test on ff

Screenshot_20240918-104930

works 👍

Copy link
Collaborator

@FelipeM525 FelipeM525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested in the simulator build!

@rohityadavcloud rohityadavcloud added this to the 4.19.2.0 milestone Sep 19, 2024
@rohityadavcloud
Copy link
Member

Sorry mea culpa - I think it 'could' break on some screens; but LGTM.

@rohityadavcloud rohityadavcloud merged commit 50d7ebf into apache:4.19 Sep 19, 2024
25 checks passed
@DaanHoogland DaanHoogland deleted the 4.19-ui-show-project-on-mobile branch September 19, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants