Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI unit test failures #9803

Closed
wants to merge 1 commit into from

Conversation

vishesh92
Copy link
Member

Description

This PR fixes unit test failures introduced in 5ab0a52

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@rohityadavcloud rohityadavcloud added this to the 4.19.2.0 milestone Oct 16, 2024
@vishesh92
Copy link
Member Author

This is already fixed in #9798. Closing.

@vishesh92 vishesh92 closed this Oct 16, 2024
@vishesh92 vishesh92 deleted the fix-ui-test-failures branch October 16, 2024 05:15
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.08%. Comparing base (017cf2c) to head (6836e2d).
Report is 2 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9803      +/-   ##
============================================
- Coverage     15.80%   15.08%   -0.72%     
- Complexity    11199    11204       +5     
============================================
  Files          5038     5404     +366     
  Lines        443875   473417   +29542     
  Branches      52607    58380    +5773     
============================================
+ Hits          70139    71428    +1289     
- Misses       365934   394040   +28106     
- Partials       7802     7949     +147     
Flag Coverage Δ
uitests 4.30% <ø> (?)
unittests 15.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohityadavcloud rohityadavcloud removed this from the 4.19.2.0 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants