Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging to include more identifiable information #9873

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

vishesh92
Copy link
Member

Description

This PR updates the logging for some modules to ensure that we log more details to easily identify resources from the logs.
e.g. We use id at a lot of places in the logs and it makes it difficult to know about the resource without querying the database. This PR makes changes to include uuid or any other relevant fields to the objects in the logs so that the user can easily identify the resource.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.04%. Comparing base (019f2c6) to head (c84082e).
Report is 26 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (019f2c6) and HEAD (c84082e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (019f2c6) HEAD (c84082e)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #9873       +/-   ##
============================================
- Coverage     15.78%   4.04%   -11.75%     
============================================
  Files          5627     392     -5235     
  Lines        492250   32170   -460080     
  Branches      61405    5677    -55728     
============================================
- Hits          77710    1301    -76409     
+ Misses       406066   30721   -375345     
+ Partials       8474     148     -8326     
Flag Coverage Δ
uitests 4.04% <ø> (+<0.01%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishesh92 vishesh92 force-pushed the improve-logging branch 2 times, most recently from 355b1e5 to 6a0dc33 Compare November 5, 2024 05:35
@apache apache deleted a comment from blueorangutan Nov 5, 2024
@apache apache deleted a comment from blueorangutan Nov 5, 2024
@vishesh92
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11508

@vishesh92
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants