-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COLLECTIONS-806] Continue JUnit v5 #293
base: master
Are you sure you want to change the base?
[COLLECTIONS-806] Continue JUnit v5 #293
Conversation
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
=========================================
Coverage 85.80% 85.80%
Complexity 4674 4674
=========================================
Files 292 292
Lines 13472 13472
Branches 1955 1955
=========================================
Hits 11560 11560
Misses 1332 1332
Partials 580 580 Continue to review full report at Codecov.
|
1596e50
to
93b0fd1
Compare
Hi @nhojpatrick |
Break Inherifance need for BulkTest constants TransformedSplitMapTest break inheritance of BulkTest IteratorIterableTest break inheritance of BulkTest Break Inheritance need for AbstractObjectTest
93b0fd1
to
5201c92
Compare
@garydgregory done, tests locally report
so will look into the JDK 17 failures reported later |
@garydgregory EmptyPropertiesTest passes locally on JDK 17, and that class is not touched in this PR so not sure how to fix it. |
Ask yourself: Does the OS matter? Does the default EOL sequence matter? Does the default Charset matter? What else is different between my environment and the GutHub build environment? |
@nhojpatrick maybe b705855 ? |
That commit only fix one of the flaky test, |
Hello @nhojpatrick |
Break Inherifance need for BulkTest constants
TransformedSplitMapTest break inheritance of BulkTest
IteratorIterableTest break inheritance of BulkTest
Break Inheritance need for AbstractObjectTest
Trying to reduce requirement for methods via inheritance, so breaking out common static or helper methods.