Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COLLECTIONS-841] Open up bloom filter tests - test changes to support bit decay based Bloom filters #400

Conversation

Claudenw
Copy link
Contributor

Changes to test setup to account for Bloom filters that use bit decay (e.g. Stable Bloom filter). These changes do not change the tests, just the way the filters are configured so that decay based filters will have the proper results.

@garydgregory garydgregory changed the title Collections 841 open up bloom filter tests - test changes to support bit decay based Bloom filters [COLLECTIONS-841] Open up bloom filter tests - test changes to support bit decay based Bloom filters Jun 21, 2023
@garydgregory
Copy link
Member

@codecov-commenter
Copy link

Codecov Report

Merging #400 (ab341b4) into master (916efdb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #400   +/-   ##
=========================================
  Coverage     81.19%   81.19%           
  Complexity     4605     4605           
=========================================
  Files           288      288           
  Lines         13424    13424           
  Branches       1983     1983           
=========================================
  Hits          10900    10900           
  Misses         1932     1932           
  Partials        592      592           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@garydgregory garydgregory merged commit 1671280 into apache:master Jun 21, 2023
6 checks passed
anantdamle pushed a commit to anantdamle/commons-collections that referenced this pull request Aug 14, 2023
…t bit decay based Bloom filters (apache#400)

* Adjusted tests to handle bloom filter implementations that utilized
automatic decay.

* fixed formatting issues

* fixed indent

* Format tweaks

---------

Co-authored-by: Gary Gregory <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants