Make AbstractPatriciaTrie public

[vad0]

I extend this class here to make an implementation which works with an AsciiSequenceView instead of String. Package visibility forces me to create a package org.apache.commons.collections4.trie in my project. This hack works, but it prevents me from migrating to the java modules system, which prohibits using the same package names in the different modules. So I think the best solution here wil be to make AbstractPatriciaTrie public.

[Claudenw]

I encountered a similar problem with AbstractPatriciaTrie but ended up not using the Trie.

[garydgregory]

Seems reasonable to make public unless I am missing something. @aherbert ?

[aherbert]

The use case merits it being made public. Note that if we make it public then it needs some more javadoc as it will now appear in the javadoc API. The types <K, V> are not documented, e.g. are there limitations? One of the constructors has no javadoc, the other has no documentation of the parameters. IIUC the minimal effort would be to copy what is in the superclass AbstractBitwiseTrie for the type parameters and the constructors. I did not check the rest of the rendered javadoc but this should be done for completeness.

[vad0]

Copied some javadocs from the parent class

[codecov-commenter]

Codecov Report

Merging #407 (b85e9da) into master (99473df) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #407   +/-   ##
=========================================
  Coverage     81.20%   81.20%           
  Complexity     4625     4625           
=========================================
  Files           290      290           
  Lines         13483    13483           
  Branches       1993     1993           
=========================================
  Hits          10949    10949           
  Misses         1933     1933           
  Partials        601      601           

Files Changed	Coverage Δ
...ommons/collections4/trie/AbstractPatriciaTrie.java	53.45% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more