Fix punctuation and minor Javadoc issues #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mawiesne
commented
Jul 29, 2023
•
mawiesne
commented
- fixes misplaced symbols in JavaDoc (mainly in Hasher, CountingLongPredicate)
- resolves grammar and punctuation issues
|
Ping @garydgregory @kinow |
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
=========================================
Coverage 81.20% 81.20%
Complexity 4625 4625
=========================================
Files 290 290
Lines 13483 13483
Branches 1993 1993
=========================================
Hits 10949 10949
Misses 1933 1933
Partials 601 601
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
garydgregory
requested changes
Jul 29, 2023
There was a problem hiding this comment.
@mawiesne
Thank you for your PR.
I am worried that this will clash with ongoing work in PRs in the bloom filter package.
Would you please update the PR to not touch that package?
kinow
approved these changes
Jul 29, 2023
…dicate) resolves grammar and punctuation issues
mawiesne
force-pushed
the
fix-grammar-and-javadoc-issues
branch
from
d82c18e
to
0668de8
Compare
I did - changes in bloomfilter package reverted. |
garydgregory
changed the title
garydgregory
added a commit
that referenced
this pull request
Jul 29, 2023
anantdamle
pushed a commit
to anantdamle/commons-collections
that referenced
this pull request
Aug 14, 2023
…dicate) (apache#409) resolves grammar and punctuation issues
anantdamle
pushed a commit
to anantdamle/commons-collections
that referenced
this pull request
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.