Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COLLECTIONS-858] Add CartesianProductIterator #509

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,156 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.commons.collections4.iterators;

import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import java.util.NoSuchElementException;
import java.util.Objects;

/**
* This iterator creates a Cartesian product of the input iterables,
* equivalent to nested for-loops.
* <p>
* The iterables provided to the constructor are used in reverse order, each
* until exhaustion before proceeding to the next element of the prior iterable
* and repeating. Consider the following example:
*
* <pre>{@code
* List<Character> iterable1 = Arrays.asList('A', 'B', 'C');
* List<Character> iterable2 = Arrays.asList('1', '2', '3');
* CartesianProductIterator<Character> it = new CartesianProductIterator<>(
* iterable1,
* iterable2);
* while (it.hasNext()) {
* List<Character> tuple = it.next();
* System.out.println(tuple.get(0) + ", " + tuple.get(1));
* }
* }</pre>
*
* The output will be:
*
* <pre>
* A, 1
* A, 2
* A, 3
* B, 1
* B, 2
* B, 3
* C, 1
* C, 2
* C, 3
* </pre>
* <p>
* The {@code remove()} operation is not supported, and will throw an
* {@code UnsupportedOperationException}.
* <p>
* If any of the input iterables is empty, the Cartesian product will be empty.
* If any of the input iterables is infinite, the Cartesian product will be
* infinite.
*
alexey-pelykh marked this conversation as resolved.
Show resolved Hide resolved
* @param <E> the type of the objects being permuted
* @since 4.5.0
*/
alexey-pelykh marked this conversation as resolved.
Show resolved Hide resolved
public class CartesianProductIterator<E> implements Iterator<List<E>> {

/**
* The iterables to create the Cartesian product from.
*/
private final List<Iterable<? extends E>> iterables;

/**
* The iterators to generate the Cartesian product tuple from.
*/
private final List<Iterator<? extends E>> iterators;

/**
* The previous generated tuple of elements.
*/
private List<E> previousTuple;

/**
* Constructs a new {@code CartesianProductIterator} instance with given iterables.
*
* @param iterables the iterables to create the Cartesian product from
* @throws NullPointerException if any of the iterables is null
*/
@SafeVarargs
public CartesianProductIterator(final Iterable<? extends E>... iterables) {
alexey-pelykh marked this conversation as resolved.
Show resolved Hide resolved
Objects.requireNonNull(iterables, "iterables");
this.iterables = new ArrayList<>(iterables.length);
this.iterators = new ArrayList<>(iterables.length);
for (final Iterable<? extends E> iterable : iterables) {
Objects.requireNonNull(iterable, "iterable");
this.iterables.add(iterable);
final Iterator<? extends E> iterator = iterable.iterator();
if (!iterator.hasNext()) {
iterators.clear();
break;
}
iterators.add(iterator);
}
}

/**
* Returns {@code true} if the iteration has more elements.
*
* @return true if there are more tuples, otherwise false
*/
@Override
public boolean hasNext() {
return iterators.stream().anyMatch(Iterator::hasNext);
}

/**
* Returns the next tuple of the input iterables.
*
* @return a list of the input iterables' elements
* @throws NoSuchElementException if there are no more tuples
*/
@Override
public List<E> next() {
if (!hasNext()) {
throw new NoSuchElementException();
}

if (previousTuple == null) {
previousTuple = new ArrayList<>(iterables.size());
for (final Iterator<? extends E> iterator : iterators) {
previousTuple.add(iterator.next());
}
return new ArrayList<>(previousTuple);
}

for (int i = iterators.size() - 1; i >= 0; i--) {
Iterator<? extends E> iterator = iterators.get(i);
if (iterator.hasNext()) {
previousTuple.set(i, iterator.next());
return new ArrayList<>(previousTuple);
}
iterator = iterables.get(i).iterator();
iterators.set(i, iterator);
previousTuple.set(i, iterator.next());
}
throw new IllegalStateException("reached unreachable code");
}

@Override
public void remove() {
throw new UnsupportedOperationException("remove");
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,209 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.commons.collections4.iterators;

import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertThrows;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import java.util.NoSuchElementException;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;


/**
* Test class for {@link CartesianProductIterator}.
*/
public class CartesianProductIteratorTest extends AbstractIteratorTest<List<Character>> {

private List<Character> letters;
private List<Character> numbers;
private List<Character> symbols;
private List<Character> emptyList;

public CartesianProductIteratorTest() {
super(CartesianProductIteratorTest.class.getSimpleName());
}

@Override
public CartesianProductIterator<Character> makeEmptyIterator() {
return new CartesianProductIterator<>();
}

@Override
public CartesianProductIterator<Character> makeObject() {
return new CartesianProductIterator<>(letters, numbers, symbols);
}

@BeforeEach
public void setUp() {
letters = Arrays.asList('A', 'B', 'C');
numbers = Arrays.asList('1', '2', '3');
symbols = Arrays.asList('!', '?');
emptyList = Collections.emptyList();
}

@Override
public boolean supportsRemove() {
return false;
}

@Test
public void testRemoveThrows() {
final CartesianProductIterator<Character> it = makeObject();
assertThrows(UnsupportedOperationException.class, it::remove);
}

@Test
public void testEmptyCollection() {
final CartesianProductIterator<Character> it = new CartesianProductIterator<>(letters, Collections.emptyList());
assertFalse(it.hasNext());
assertThrows(NoSuchElementException.class, it::next);
}
alexey-pelykh marked this conversation as resolved.
Show resolved Hide resolved

/**
* test checking that all the tuples are returned
*/
@Test
public void testExhaustivity() {
final List<Character[]> resultsList = new ArrayList<>();
final CartesianProductIterator<Character> it = makeObject();
while (it.hasNext()) {
final List<Character> tuple = it.next();
resultsList.add(tuple.toArray(new Character[0]));
}
assertThrows(NoSuchElementException.class, it::next);
assertEquals(18, resultsList.size());
final Iterator<Character[]> itResults = resultsList.iterator();
for (final Character a : letters) {
for (final Character b : numbers) {
for (final Character c : symbols) {
assertArrayEquals(new Character[]{a, b, c}, itResults.next());
}
}
}
}

/**
* test checking that no tuples are returned when at least one of the lists is empty
*/
@Test
public void testExhaustivityWithEmptyList() {
final List<Character[]> resultsList = new ArrayList<>();
final CartesianProductIterator<Character> it = new CartesianProductIterator<>(letters, emptyList, symbols);
while (it.hasNext()) {
final List<Character> tuple = it.next();
resultsList.add(tuple.toArray(new Character[0]));
}
assertThrows(NoSuchElementException.class, it::next);
assertEquals(0, resultsList.size());
}

alexey-pelykh marked this conversation as resolved.
Show resolved Hide resolved
/**
* test checking that no tuples are returned when first of the lists is empty
*/
@Test
public void testExhaustivityWithEmptyFirstList() {
final List<Character[]> resultsList = new ArrayList<>();
final CartesianProductIterator<Character> it = new CartesianProductIterator<>(emptyList, numbers, symbols);
while (it.hasNext()) {
final List<Character> tuple = it.next();
resultsList.add(tuple.toArray(new Character[0]));
}
assertThrows(NoSuchElementException.class, it::next);
assertEquals(0, resultsList.size());
}

/**
* test checking that no tuples are returned when last of the lists is empty
*/
@Test
public void testExhaustivityWithEmptyLastList() {
final List<Character[]> resultsList = new ArrayList<>();
final CartesianProductIterator<Character> it = new CartesianProductIterator<>(letters, numbers, emptyList);
while (it.hasNext()) {
final List<Character> tuple = it.next();
resultsList.add(tuple.toArray(new Character[0]));
}
assertThrows(NoSuchElementException.class, it::next);
assertEquals(0, resultsList.size());
}

/**
* test checking that no tuples are returned when all the lists are empty
*/
@Test
public void testExhaustivityWithAllEmptyLists() {
final List<Character[]> resultsList = new ArrayList<>();
final CartesianProductIterator<Character> it = new CartesianProductIterator<>(emptyList, emptyList, emptyList);
while (it.hasNext()) {
final List<Character> tuple = it.next();
resultsList.add(tuple.toArray(new Character[0]));
}
assertThrows(NoSuchElementException.class, it::next);
assertEquals(0, resultsList.size());
}

/**
* test checking that all tuples are returned when same list is passed multiple times
*/
@Test
public void testExhaustivityWithSameList() {
final List<Character[]> resultsList = new ArrayList<>();
final CartesianProductIterator<Character> it = new CartesianProductIterator<>(letters, letters, letters);
while (it.hasNext()) {
final List<Character> tuple = it.next();
resultsList.add(tuple.toArray(new Character[0]));
}
assertThrows(NoSuchElementException.class, it::next);
assertEquals(27, resultsList.size());
final Iterator<Character[]> itResults = resultsList.iterator();
for (final Character a : letters) {
for (final Character b : letters) {
for (final Character c : letters) {
assertArrayEquals(new Character[]{a, b, c}, itResults.next());
}
}
}
}

/**
* test that all tuples are provided to consumer
*/
@Test
public void testForEachRemaining() {
final List<Character[]> resultsList = new ArrayList<>();
final CartesianProductIterator<Character> it = makeObject();
it.forEachRemaining(tuple -> resultsList.add(tuple.toArray(new Character[0])));
assertEquals(18, resultsList.size());
final Iterator<Character[]> itResults = resultsList.iterator();
for (final Character a : letters) {
for (final Character b : numbers) {
for (final Character c : symbols) {
assertArrayEquals(new Character[]{a, b, c}, itResults.next());
}
}
}
}
}