Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify method CollectionUtils#isEqualCollection #529

Closed
wants to merge 3 commits into from

Conversation

StudentGu
Copy link

Simplify method CollectionUtils#isEqualCollection

@garydgregory
Copy link
Member

garydgregory commented Sep 1, 2024

@StudentGu

Thank you for your PR.

I removed some duplication in CardinalityHelper and the class now reuses the existing HashBag class, see CollectionUtils.CardinalityHelper.equals(Collection<?>, Collection<?>):

static boolean equals(final Collection<?> a, final Collection<?> b) {
return new HashBag<>(a).equals(new HashBag<>(b));
}

This PR can be closed IMO.

@StudentGu
Copy link
Author

@StudentGu

Thank you for your PR.

I removed some duplication in CardinalityHelper and the class now reuses the existing HashBagclass, seeorg.apache.commons.collections4.CollectionUtils.CardinalityHelper.equals(Collection, Collection)`:

static boolean equals(final Collection<?> a, final Collection<?> b) {
return new HashBag<>(a).equals(new HashBag<>(b));
}

This PR can be closed IMO.

@garydgregory

Oh, My brother, I want contribute to the project.

@garydgregory
Copy link
Member

Hello @StudentGu

If you are looking for contribution inspiration, please see https://issues.apache.org/jira/projects/COLLECTIONS

Closing: Information provided.

@StudentGu StudentGu deleted the dev branch September 4, 2024 06:40
@StudentGu
Copy link
Author

StudentGu commented Sep 4, 2024

Thanks! @garydgregory
It is a great pity that I don't have an jira account now.
I have applied to the community for an jira account through https://selfserve.apache.org/jira-account.html and select the commons-collections, but there has been no reply.
Could you help me deal with it?

@garydgregory
Copy link
Member

@StudentGu
All you have to do to get a Jira account is apply. The application form exists to avoid bots from creating tickets and spam which was a problem in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants