Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COLLECTIONS 714] Add tests #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rohanpadhye
Copy link

Adding two tests that demonstrate the bug reported in COLLECTIONS-714. The tests currently fail, since I don't have a fix for the bug.

@garydgregory
Copy link
Member

Since the tests fail, please decorate the methods with @ignore("COLLECTIONS-714")

@rohanpadhye
Copy link
Author

The @Ignore annotation only appears to work with JUnit4-style tests (org.junit.Test). The PatriciaTrieTest suite appears to using a JUnit3 style (junit.framework.Test), which doesn't support @Ignore. Am I mistaken here?

I have given project maintainers edit access to this pull request, so feel free to push any changes you desire directly to the bug-collections-714 branch.

@garydgregory
Copy link
Member

@rohanpadhye You are not mistaken indeed. Commons Collections needs a port to JUnit 4 for @Ignore to to work properly. We cannot merge this patch as is since it will make the build fail.

@saipraneethn
Copy link

You can add a prefix of X for those test cases as the JUnit will be looking for the methods starting with test.

@garydgregory
Copy link
Member

You can add a prefix of X for those test cases as the JUnit will be looking for the methods starting with test.

Don't do that, that's why one uses @Ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants