--corrected the isUnchecked method to check for null (#1079)

--created test for null case
apache · Jul 3, 2023 · f68a643 · f68a643
1 parent 6ea4e39
commit f68a643
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java b/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java
@@ -641,7 +641,7 @@ public static boolean isChecked(final Throwable throwable) {
      * @since 3.13.0
      */
     public static boolean isUnchecked(final Throwable throwable) {
-        return !isChecked(throwable);
+        return throwable != null && (throwable instanceof Error || throwable instanceof RuntimeException);
     }
 
     /**

diff --git a/src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java b/src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java
@@ -635,6 +635,11 @@ public void testIsCheckedCustomThrowable() {
         assertTrue(ExceptionUtils.isChecked(new TestThrowable()));
     }
 
+    @Test
+    public void testIsUnchecked_null() {
+        assertFalse(ExceptionUtils.isUnchecked(null));
+    }
+
     @Test
     public void testIsUnchecked_checked() {
         assertFalse(ExceptionUtils.isUnchecked(new IOException()));