deprecated ObjectUtils defaultIfNull in favor or getIfNull overload getFirstNonNull with collection support#1355
deprecated ObjectUtils defaultIfNull in favor or getIfNull overload getFirstNonNull with collection support#1355Pankraz76 wants to merge 1 commit intoapache:masterfrom
defaultIfNull in favor or getIfNull overload getFirstNonNull with collection support#1355Conversation
2b7c79c to
127466b
Compare
|
is this any good? |
15426f9 to
695e32a
Compare
defaultIfNull add getIfNull and getFirstNonNulldefaultIfNull in favor or getIfNull overload getFirstNonNull with collection support
695e32a to
0f07d62
Compare
0f07d62 to
60eb430
Compare
defaultIfNull(Object, Object) A adaptation of PR #1355 by Pankraz76
|
Hello @Pankraz76 There are conflicts in the PR so I brought this in slightly differently in git master. You are credited in the commit comment and TY! |
|
thx. |
|
Out of curiosity, why is this rename/deprecation useful? Subjectively, |
|
The TODO directive given, it's considered deprecated to avoid breaking change. I like both approaches, but the default context is somewhat implied. While having a verbose API is nice for beginners, for those used to it, this feels like overhead. Since it's either/or, why do we need to explicitly mention the default? Asking this question could argue why not renaming to considering: big scope -> small name small scope -> big name |
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.