Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add StringUtils.substringBeforeLast(String, int) #967

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmariotti
Copy link

Hello,
This method with int param is missing :)

Hello,
This method with int param is missing :)
@mmariotti mmariotti changed the title add StringUtils.ubstringBeforeLast(String, int) add StringUtils.substringBeforeLast(String, int) Oct 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #967 (731f99b) into master (ff733d9) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #967      +/-   ##
============================================
- Coverage     91.99%   91.96%   -0.03%     
- Complexity     7432     7433       +1     
============================================
  Files           189      189              
  Lines         15664    15670       +6     
  Branches       2907     2908       +1     
============================================
+ Hits          14410    14411       +1     
- Misses          677      683       +6     
+ Partials        577      576       -1     
Impacted Files Coverage Δ
...ain/java/org/apache/commons/lang3/StringUtils.java 98.45% <0.00%> (-0.36%) ⬇️
...apache/commons/lang3/reflect/ConstructorUtils.java 86.00% <0.00%> (+2.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arturobernalg
Copy link
Member

HI @mmariotti
Thank you for your PR. Can you add test cases that cover all the possible path?

TY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants