Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: deprecate CordovaPlugin's method initialize #1771

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

erisu
Copy link
Member

@erisu erisu commented Jan 27, 2025

Motivation, Context & Description

It is recommended to use pluginInitialize and not initialize.

At one point initialize was deprecated but later the flag was removed. This PR is re-adding the flag to make aware that the initialize method is deprecated and will be removed in a future release. Plugin developers should switch to pluginInitialize.

The question about this originated from doc repo: apache/cordova-docs#1386

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added this to the 14.0.0 milestone Jan 27, 2025
@erisu erisu added the bug label Jan 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.50%. Comparing base (dff2fc6) to head (9a2ef2b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1771   +/-   ##
=======================================
  Coverage   72.50%   72.50%           
=======================================
  Files          23       23           
  Lines        1837     1837           
=======================================
  Hits         1332     1332           
  Misses        505      505           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erisu erisu merged commit b623311 into apache:master Jan 28, 2025
14 checks passed
@erisu erisu deleted the feat/deprecate-CordovaPlugin-initialize branch January 28, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants