feat(android): Progress report for Media plugin (CB-7175) #22
Conversation
This is call when there is progress on buffering remote media.
…ing MediaPlayer.OnBufferingUpdateListener
src/android/AudioPlayer.java
Outdated
| @@ -277,6 +280,16 @@ public void onCompletion(MediaPlayer player) { | |||
| } | |||
|
|
|||
| /** | |||
| * Callback to be invoked when progress has been made on buffering media source | |||
| * | |||
| * @param player The MediaPlayer that reached the end of the file | |||
There was a problem hiding this comment.
that reached the end of file sounds wrong... based on the callback name.
|
All issues you mentioned are now fixed, @jsoref. |
|
That's great, @emilsedgh -- do you have an ICLA on file with Apache? I can't find your name on the list there, and we usually ask for one from contributors, just so that we know we can use your code without problems. You can see the details here, if you haven't: http://www.apache.org/licenses/#clas Thanks! |
|
@clelland I just submitted mine. Thank you for finally looking into this :) |
|
Hi emilsedgh! Great job! 12:01:29 PM :: 1 Seems the code is working but I can't understand what I need to change to skip this notifications and get the progress of buffering. And another question, how to stop the callback when the buffering is done? |
|
Ok I find the solution for the fails. For the new vrsion of plugin I change the plugin calling path to "cordova.require('cordova-plugin-media.Media')" But still don't understand how to stop gathering the buffering status after it reachs the 100% I'm not familar with Java :( |
|
What do you mean 'after it reaches 100%'. |
|
It loops like 'forever' 100% aproximately every second. I've found on net that it's Samsung bug and trying to add some aditional condition to keep the reaching 100% status and break the callback for that |
|
Hey @emilsedgh, I know it has been a long time but there are conflicts now. Could you maybe rebase you branch on master to get those fixed? Thanks. |
janpio
changed the title
Fixes CB-7175