[WIP] Add support for BNLJ #343
Draft
+152
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @singhpk234. I see this is marked WIP so will hold off on reviewing until it is ready for review. Let us know if you need any help or have questions. |
|
I saw this is in WIP for a while. @singhpk234 Would you like to continue working on it? Or we can have someone take it over? Thanks. |
|
Apologies @andygrove @viirya got swamped by internal company work and lost track of this pr, i would able to make it ready for review by EOW for sure (thinking of utilizing this weekend for the same) if it's fine ? |
|
No worries. Just want to make sure if you still work on it. If not, we could have someone pick it up. Thanks. |
|
Thanks @viirya for sure I am on it from now ! |
singhpk234
force-pushed
the
feature/support-bnlj
branch
from
5e9e8c5
to
daa2f6b
Compare
|
Moving this to draft for now since it has been inactive for a while |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.#198
Rationale for this change
What changes are included in this PR?
Support for BNLJ, this supports is missing in supported joins
How are these changes tested?
UT