feat: Array element extraction #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
reviewed
Sep 4, 2024
native/spark-expr/src/list.rs
Outdated
| self: Arc<Self>, | ||
| children: Vec<Arc<dyn PhysicalExpr>>, | ||
| ) -> datafusion_common::Result<Arc<dyn PhysicalExpr>> { | ||
| Ok(Arc::new(ListExtract::new( |
There was a problem hiding this comment.
nit: perhaps add an assertion that children is of the expected length
There was a problem hiding this comment.
Sure. Out of curiosity is this part of physical expressions (with_new_children) actually used in how Comet is using DataFusion?
There was a problem hiding this comment.
It will be once #907 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #898
Rationale for this change
More array/list support. Implemented a custom PhysicalExpr rather than using DataFusion's
ArrayElementto support ANSI fail on error, default value, and GetArrayItem's zero based indexing.What changes are included in this PR?
Support for array extraction via the Spark
GetArrayItemandElementAtexpressions.How are these changes tested?
New UT