chore: Enable additional CreateArray tests #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimahriman
commented
Sep 9, 2024
| @@ -1855,7 +1855,7 @@ impl PhysicalPlanner { | |||
| .into_iter() | |||
| .zip(input_expr_types.into_iter().zip(coerced_input_types)) | |||
| .map(|(expr, (from_type, to_type))| { | |||
| if !from_type.equals_datatype(&to_type) { | |||
| if from_type != to_type { | |||
There was a problem hiding this comment.
MutableArrayData checks for exact equality across types, including field names, so need to be stricter about deciding when casts are needed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #928 +/- ##
============================================
+ Coverage 34.03% 34.04% +0.01%
+ Complexity 883 882 -1
============================================
Files 113 112 -1
Lines 43170 43290 +120
Branches 9516 9553 +37
============================================
+ Hits 14693 14739 +46
- Misses 25471 25537 +66
- Partials 3006 3014 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow up to #792
Rationale for this change
Enable additional
CreateArraytests now that we've bumped the DataFusion version in #909What changes are included in this PR?
Enable additional tests, and make on change to the equality check for type coercion to fix one of the new tests.
How are these changes tested?
New tests enabled