pretty print improvements #1851
Open
+356
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also improves performance and simplifies pretty-printing
see apache#1850 all the tests are skipped at the moment, we will enable them as we implement more pretty printing
- Refactor DisplayCommaSeparated to accept any iterable type. - Update indented_list to work with iterators. - Improve formatting in the Insert display implementation
iffyio
reviewed
May 14, 2025
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
| let mut first = true; | ||
| for t in self.0 { | ||
| for t in self.0.clone() { |
There was a problem hiding this comment.
was the clone needed here, we seem to only call fmt on t?
There was a problem hiding this comment.
Yes, we are never actually cloning anything expensive here, but we need to add the Clone generic bound in order to be able to use the IntoIterator trait.
This .clone() concretely always clones
- either just a reference (to a slice)
- or an iterator object (but not the underlying structure being iterated on)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a first PR for #1850
mainly implementing pretty printing for insert update and delete statements