MySQL: CREATE INDEx: allow USING clause before ON
#2029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MySQL allows specifying the index type `USING index_type` before the `ON` clause in `CREATE INDEX` statements. This PR allows the `CREATE INDEX` parser to accept both positions of the `USING` clause, regardless of the dialect. docs: https://dev.mysql.com/doc/refman/8.4/en/create-index.html
MohamedAbdeen21
commented
Sep 15, 2025
| let concurrently = self.parse_keyword(Keyword::CONCURRENTLY); | ||
| let if_not_exists = self.parse_keywords(&[Keyword::IF, Keyword::NOT, Keyword::EXISTS]); | ||
|
|
||
| let mut using = None; |
There was a problem hiding this comment.
Not a fan of this mut but also not a fan of returning a tuple of (index_name, using) at line 7067.
The second test in parse_create_index_using_before_on was redundant.
mvzink
suggested changes
Sep 15, 2025
| let concurrently = self.parse_keyword(Keyword::CONCURRENTLY); | ||
| let if_not_exists = self.parse_keywords(&[Keyword::IF, Keyword::NOT, Keyword::EXISTS]); | ||
|
|
||
| let mut using = None; |
iffyio
reviewed
Sep 19, 2025
iffyio
changed the title
CREATE INDEx: allow USING clause before ON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL allows specifying the index type
USING index_typebefore theONclause inCREATE INDEXstatements.This PR allows the
CREATE INDEXparser to accept both positions of theUSINGclause, regardless of the dialect.docs: https://dev.mysql.com/doc/refman/8.4/en/create-index.html