Impl spark bit not function #17155
Open
Impl spark bit not function #17155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
reviewed
Aug 28, 2025
| #[derive(Debug)] | ||
| pub struct SparkBitNot { | ||
| signature: Signature, | ||
| aliases: Vec<String>, |
There was a problem hiding this comment.
Remove aliases field if it's not used
Comment on lines
+67
to
+77
| Ok(match arg_types[0] { | ||
| DataType::Int8 => DataType::Int8, | ||
| DataType::Int16 => DataType::Int16, | ||
| DataType::Int32 => DataType::Int32, | ||
| DataType::Int64 => DataType::Int64, | ||
| DataType::Null => DataType::Null, | ||
| _ => { | ||
| return exec_err!( | ||
| "{} function can only accept integral arrays", | ||
| self.name() | ||
| ) |
There was a problem hiding this comment.
I feel this should be encoded in the signature?
| DataType::Int16 => bit_not_op!(value_array, Int16Type, Int16Array), | ||
| DataType::Int32 => bit_not_op!(value_array, Int32Type, Int32Array), | ||
| DataType::Int64 => bit_not_op!(value_array, Int64Type, Int64Array), | ||
| _ => exec_err!("bit_not can't be evaluated because the expression's type is {:?}, not signed int", value_array.data_type()), |
There was a problem hiding this comment.
Why is this function limited to only signed integer types?
| @@ -34,8 +36,9 @@ pub mod expr_fn { | |||
| "Returns the number of bits set in the binary representation of the argument.", | |||
| col | |||
| )); | |||
| export_functions!((bit_not, "Returns the result of a bitwise negation operation on the argument, where each bit in the binary representation is flipped, following two's complement arithmetic for signed integers.", col)); | |||
There was a problem hiding this comment.
Is it necessary to add the detail about two's complement here?
Jefffrey
reviewed
Aug 28, 2025
Comment on lines
+90
to
+99
| macro_rules! bit_not_op { | ||
| ($OPERAND:expr, $PT:ident, $AT:ident) => {{ | ||
| let result: $AT = $OPERAND | ||
| .as_primitive::<$PT>() | ||
| .iter() | ||
| .map(|x| x.map(|y| !y)) | ||
| .collect(); | ||
| Ok(Arc::new(result)) | ||
| }}; | ||
| } |
There was a problem hiding this comment.
It is possible to just use the arrow compute kernel here?
https://docs.rs/arrow/latest/arrow/compute/kernels/bitwise/fn.bitwise_not.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of [EPIC] Complete
datafusion-sparkSpark Compatible Functions #15914.Rationale for this change
What changes are included in this PR?
Implement spark bit_not function
Are these changes tested?
Added unit tests
Are there any user-facing changes?
Yes, new function on spark crate