Extract complex default impls from AggregateUDFImpl trait #17391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract AggregateUDFImpl method that have complex implementations. This makes it feasible to implement that trait with `#[warn(clippy::missing_trait_methods)]` Clippy check enabled. That check is very helpful when the type implementing `AggregateUDFImpl` delegates many methods to another `AggregateUDFImpl` implementation and therefore does not want to unconsciously rely on default implementation. Sadly, Rust does not allow explicitly delegating to trait method's default implementation. Extracting the logic to standalone functions works around that limitation.
timsaucer
approved these changes
Sep 4, 2025
comphead
reviewed
Sep 4, 2025
comphead
reviewed
Sep 4, 2025
findepi
force-pushed
the
findepi/extract-complex-default-impls-from-aggregateudfimpl-trait-dfff56
branch
from
072a94c to
13f4a1c
Compare
…plex-default-impls-from-aggregateudfimpl-trait-dfff56
alamb
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract AggregateUDFImpl method that have complex implementations. This makes it feasible to implement that trait with
#[warn(clippy::missing_trait_methods)]Clippy check enabled. That check is very helpful when the type implementingAggregateUDFImpldelegates many methods to anotherAggregateUDFImplimplementation and therefore does not want to unconsciously rely on default implementation. Sadly, Rust does not allow explicitly delegating to trait method's default implementation. Extracting the logic to standalone functions works around that limitation.