fix: synchronize partition bounds reporting in HashJoin #17452
+146
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
rkrishn7
commented
Sep 6, 2025
| @@ -61,6 +62,12 @@ impl FileOpener for TestOpener { | |||
| _file_meta: FileMeta, | |||
| _file: PartitionedFile, | |||
| ) -> Result<FileOpenFuture> { | |||
| if let Some(predicate) = &self.predicate { | |||
There was a problem hiding this comment.
Will take this out, just leaving here for now for visualization.
I wonder what are good ways to regression test this 🤔
There was a problem hiding this comment.
The best I can think of would be to make a custom ExecutionPlan that delays partition 0 for 1s or something and check that we still read the expected number of rows on the probe side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Adds a simple synchronization mechanism (
BoundsWaiter) for tasks to wait on complete bounds for left side and for the dynamic filter expr to be built.Are these changes tested?
Not presently, open to ideas on regression tests we can add!
Are there any user-facing changes?