Skip to content

Improve error message when string functions receive Binary types #19819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 4 commits into from
Jan 22, 2026
+26 −11
Merged

Improve error message when string functions receive Binary types #19819

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62d712e
fix: improve error message for type coercion failures
lemorage Jan 16, 2026
8fc2842
test: add tests for verifying error msg when string functions receive…
lemorage Jan 17, 2026
a517432
Merge branch 'main' into hotfix/coerce
lemorage Jan 17, 2026
4439926
test: update test expectations for new type coercion error format
lemorage Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions datafusion/expr/src/type_coercion/functions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,8 +635,13 @@ fn get_valid_types(
default_casted_type.default_cast_for(current_type)?;
new_types.push(casted_type);
} else {
return internal_err!(
"Expect {} but received NativeType::{}, DataType: {}",
let hint = if matches!(current_native_type, NativeType::Binary) {
"\n\nHint: Binary types are not automatically coerced to String. Use CAST(column AS VARCHAR) to convert Binary data to String."
} else {
""
};
return plan_err!(
"Function '{function_name}' requires {}, but received {} (DataType: {}).{hint}",
param.desired_type(),
current_native_type,
current_type
Expand Down
Loading