Skip to content

Conversation

@ChanTsune
Copy link

Which issue does this PR close?

Rationale for this change

Switching from xz2 to liblzma enabled wasm builds (liblzma supports wasm),
so we can now enable the compression feature in wasm tests.

What changes are included in this PR?

  • Add the compression feature to the datafusion dependency in datafusion/wasmtest/Cargo.toml.

Are these changes tested?

  • Verified by CI in this PR.

Are there any user-facing changes?

  • No. (test configuration change only)

`Switch from xz2 to liblzma to reduce duplicate dependencies (apache#17509)` made it possible to compile to wasm (liblzma supports wasm), so enable the compression feature in wasmtest.

Refs: apache#17509
@Jefffrey
Copy link
Contributor

Do the existing tests in wasmtest utilize the compression feature or would we need to add a new one?

@ChanTsune
Copy link
Author

The existing wasm tests do not use the compression feature.
I have verified that the crate can be compiled for the wasm target.
If tests that exercise the compression feature are required, I will add them in this PR.

@Jefffrey
Copy link
Contributor

The existing wasm tests do not use the compression feature. I have verified that the crate can be compiled for the wasm target. If tests that exercise the compression feature are required, I will add them in this PR.

It would be good to add a test

@ChanTsune
Copy link
Author

I added test code!

@Jefffrey Jefffrey added this pull request to the merge queue Jan 21, 2026
Merged via the queue into apache:main with commit 406e5aa Jan 21, 2026
31 checks passed
@Jefffrey
Copy link
Contributor

Thanks @ChanTsune

@ChanTsune
Copy link
Author

@Jefffrey thank you for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants