Main21 #651
Merged
Main21 #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/test/java/org/apache/datasketches/hash/MurmurHash3FFM21bTest.java
Dismissed
Show dismissed
Hide dismissed
AlexanderSaydakov
approved these changes
Feb 24, 2025
Some of the //TODOs were left over from Kevin's C code, so I left the comment but removed the TODO. Java can't do "INLINE CODE". This includes a new, very detailed test of the HLL growth transitions and sizes.
src/test/java/org/apache/datasketches/hll/SizeAndModeTransitions.java
Dismissed
Show resolved
Hide resolved
src/test/java/org/apache/datasketches/hll/SizeAndModeTransitions.java
Dismissed
Show dismissed
Hide dismissed
src/test/java/org/apache/datasketches/hll/SizeAndModeTransitions.java
Dismissed
Show dismissed
Hide dismissed
src/test/java/org/apache/datasketches/hll/SizeAndModeTransitions.java
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves DS-Java from JDK 17 to JDK 21. Lots of changes.
DS-Memory 6.0.0 is now released, all workflows pass. So this is ready to go.