Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][dolphinscheduler-dist] Reduce binary distribution file size #16128

Closed
wants to merge 10 commits into from

Conversation

zhuxt2015
Copy link
Contributor

Purpose of the pull request

#16125

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun
Copy link
Member

+1 if this PR submit to 3.2.2.
-1 If this PR submit to dev, since this is not a correct way to solve the dependency issue, only hide the problem.

@SbloodyS
Copy link
Member

+1 if this PR submit to 3.2.2. -1 If this PR submit to dev, since this is not a correct way to solve the dependency issue, only hide the problem.

Agreed.

@SbloodyS SbloodyS added the 3.2.2 label Jun 11, 2024
@SbloodyS SbloodyS added this to the 3.2.2 milestone Jun 11, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Jun 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.72%. Comparing base (834c320) to head (ea25013).

Current head ea25013 differs from pull request most recent head 6550763

Please upload reports for the commit 6550763 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16128      +/-   ##
============================================
+ Coverage     40.71%   40.72%   +0.01%     
- Complexity     5246     5250       +4     
============================================
  Files          1385     1385              
  Lines         46109    46109              
  Branches       4923     4923              
============================================
+ Hits          18771    18779       +8     
+ Misses        25412    25403       -9     
- Partials       1926     1927       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhuxt2015
Copy link
Contributor Author

image

@SbloodyS How can I resolve this error

@SbloodyS
Copy link
Member

image @SbloodyS How can I resolve this error

You can try this command locally

./mvnw -B clean install \
          -Dmaven.test.skip \
          -Dmaven.javadoc.skip \
          -Dspotless.skip=true \
          -Pdocker,release -Ddocker.tag=ci

@zhuxt2015
Copy link
Contributor Author

zhuxt2015 commented Jun 14, 2024

re-run CI

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change your target branch to 3.2.2-prepare @zhuxt2015

@zhuxt2015 zhuxt2015 changed the base branch from dev to 3.2.2-prepare June 18, 2024 12:57
@zhuxt2015 zhuxt2015 changed the base branch from 3.2.2-prepare to dev June 18, 2024 12:57
Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zhuxt2015 zhuxt2015 changed the base branch from dev to 3.2.2-prepare June 19, 2024 05:48
@zhuxt2015 zhuxt2015 changed the base branch from 3.2.2-prepare to dev June 19, 2024 05:49
@zhuxt2015 zhuxt2015 closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 backend improvement make more easy to user or prompt friendly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants