Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-16264][Task Plugin] Add Aliyun ADB Spark Task Plugin #16265

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

dcoliversun
Copy link

@dcoliversun dcoliversun commented Jul 3, 2024

Purpose of the pull request

This PR aims to add Aliyun ADB Spark Task Plugin, close #16264

Brief change log

  • Add adb spark task module to task-all pom.xml
  • Add adb spark datasource module to datasource-all pom.xml

Verify this pull request

This change added tests and can be verified as follows:

  • Added adb spark task tests for unit test.
  • Added adb spark datasource tests for unit test.
  • Manually verified the change by testing locally.

Copy link

boring-cyborg bot commented Jul 3, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

@dcoliversun
Copy link
Author

cc @SbloodyS could you please review this PR if you have time :)

@SbloodyS
Copy link
Member

SbloodyS commented Jul 3, 2024

Like #16127, please find a PMC/Committer that is willing to maintain this task plugin on an ongoing basis. Otherwise we won't accept it. @dcoliversun

@dcoliversun
Copy link
Author

@SbloodyS Thanks for your mention. We will work with @davidzollo to jointly maintain the adb spark plugin. cc @leesf

Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@dcoliversun
Copy link
Author

@SbloodyS @davidzollo Conflict and error are solved, maybe we can approve github action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Task Plugin] Add Aliyun ADB Spark Task Plugin
2 participants