[Feature-16300][registry] Added Consul-based Register implementation #16301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to create a DSIP firstly. |
ruanwenjun
requested changes
Jul 10, 2024
Comment on lines
+986
to
+991
|
|
||
| <dependency> | ||
| <groupId>com.orbitz.consul</groupId> | ||
| <artifactId>consul-client</artifactId> | ||
| <version>${consul-client.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
-1 to this.
Since we already have multiple registry plugins, add a new one registry plugin is not a urgent need.
And this repo has been archived. https://github.com/rickfast/consul-client
There was a problem hiding this comment.
-1 to this.
Since we already have multiple registry plugins, add a new one registry plugin is not a urgent need.
And this repo has been archived. https://github.com/rickfast/consul-client
+1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
related issue: #16300
Implemented Register based on Consul.
Brief change log
/dolphinscheduler-registry/dolphinscheduler-plugins/dolphinscheduler-registry-consul/com.orbitz.consul.consul-clientdependency indolphinscheduler-bom/pom.xmldolphinscheduler-registry-consuldependency indolphinscheduler-registry/dolphinscheduler-registry-all/pom.xmlVerify this pull request
Inherited
RegistryTestCasein/dolphinscheduler-registry/dolphinscheduler-plugins/dolphinscheduler-registry-consul/src/test/java, which can be directly run for verification.