Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature-15837] [api] Auto create workflow while import sql script #16319

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[feature-15837] [api] Auto create workflow while import sql script #16319

wants to merge 1 commit into from
+833 −98

Conversation

eye-gu
Copy link
Contributor

@eye-gu eye-gu commented Jul 15, 2024

Purpose of the pull request

close #15837

@github-actions github-actions bot added UI ui and front end related backend test labels Jul 15, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 15, 2024
View reviewed changes
...hinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/task/SqlTaskParseContext.java

import lombok.Data;

@Data

Check notice

Code scanning / CodeQL

Exposing internal representation Note

setProcessProperties exposes the internal representation stored in field processProperties. The value may be modified
through the variable processProperties
Loading
.
...hinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/task/SqlTaskParseContext.java

private Map<String, Object> processProperties;

private Map<String, Object> hints;

Check notice

Code scanning / CodeQL

Exposing internal representation Note

getHints exposes the internal representation stored in field hints. The value may be modified
after this call to getHints
Loading
.
songjianet
songjianet previously approved these changes Jul 15, 2024
View reviewed changes
SbloodyS
SbloodyS requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this feature. The scope of use of this feature is very small. I'm -1 on this.

@eye-gu
Copy link
Contributor Author

eye-gu commented Jul 16, 2024

I think we don't need this feature. The scope of use of this feature is very small. I'm -1 on this.

This feature is old and the function already exists. If it is no longer needed, should the relevant code be deleted because it is no longer available?

@eye-gu eye-gu force-pushed the feature-15837 branch 2 times, most recently from 763725b to 0c3c361 Compare July 18, 2024 03:49
@SbloodyS
Copy link
Member

SbloodyS commented Aug 2, 2024

This feature is old and the function already exists. If it is no longer needed, should the relevant code be deleted because it is no longer available?

You can create an issue first to call a vote for this. I'm +1 on this.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
58.6% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SbloodyS SbloodyS SbloodyS requested changes

@songjianet songjianet songjianet left review comments

@Amy0104 Amy0104 Awaiting requested review from Amy0104

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@eye-gu eye-gu

Labels
backend don't merge test UI ui and front end related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][api] Auto create workflow while import sql script
3 participants
@eye-gu @SbloodyS @songjianet