-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-16331] fix the resource file cannot be displayed hierarchically #16336
base: dev
Are you sure you want to change the base?
Conversation
dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/bin/start.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please make the CI happy.
mvn spotless:apply
Do I need to resubmit? |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we may have the same folder under different tenant.
e.g.
/dolphinscheduler/tenant1/resources/spark/xx.jar
/dolphinscheduler/tenant2/resources/spark/yy.jar
If we show the folder here, there may exist two spark directory here? this will cause confusion.
For this case, I think we can keep Are you still working on this? @JohnZp |
Purpose of the pull request
fix #16331
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md