Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16567] Unable to delete copied nodes in unsaved workflow #16576

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

Xuxiaotuan
Copy link

fix #16567
If a node is copied in an existing workflow, it cannot be deleted without being saved

Purpose of the pull request

Brief change log

  1. Fix the handling logic for when the backend API returns an empty array
  2. If the dependent Lineage Task List is empty, no further query is required

Verify this pull request

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

…rray

2. If the dependent Lineage Task List is empty, no further query is required
Copy link

boring-cyborg bot commented Sep 3, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

@github-actions github-actions bot added UI ui and front end related backend labels Sep 3, 2024
@SbloodyS SbloodyS changed the title [fix-16567]Unable to delete copied nodes in unsaved workflow [Fix-16567] Unable to delete copied nodes in unsaved workflow Sep 4, 2024
@SbloodyS SbloodyS added first time contributor First-time contributor bug Something isn't working labels Sep 4, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Sep 4, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed. Please fix it. @Xuxiaotuan

@Xuxiaotuan
Copy link
Author

Read the wrong message is: " Error: The archive file /home/runner/.m2/repository/com/github/eirslett/node/16.13.1/node-16.13.1-linux-x64.tar.gz is corrupted and will be deleted. Please try the build again."

CI may need to be executed again, and Quality Gate failure I don't know what to do with this

Comment on lines 38 to 42
(item: any) => item.processDefinitionCode !== workflowCode
)
.forEach((item: any) => {
tasks.push(
item.processDefinitionName + '->' + item.taskDefinitionName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(item: any) => item.processDefinitionCode !== workflowCode
)
.forEach((item: any) => {
tasks.push(
item.processDefinitionName + '->' + item.taskDefinitionName
(item: any) => item.workflowDefinitionCode !== workflowCode
)
.forEach((item: any) => {
tasks.push(
item.workflowDefinitionName + '->' + item.taskDefinitionName

@SbloodyS
Copy link
Member

SbloodyS commented Sep 5, 2024

Read the wrong message is: " Error: The archive file /home/runner/.m2/repository/com/github/eirslett/node/16.13.1/node-16.13.1-linux-x64.tar.gz is corrupted and will be deleted. Please try the build again."

CI may need to be executed again, and Quality Gate failure I don't know what to do with this

Node related error are caused by network fluctuations, and you don't need to care about Quality Gate in this PR.

Xuxiaotuan and others added 2 commits September 5, 2024 10:36
# Conflicts:
#	dolphinscheduler-ui/src/views/projects/components/dependencies/use-dependencies.ts
@Xuxiaotuan
Copy link
Author

The front-end and code standards, along with the suggestions for modification, have been revised. Assistance is needed to execute the CI @SbloodyS

@SbloodyS
Copy link
Member

The front-end and code standards, along with the suggestions for modification, have been revised. Assistance is needed to execute the CI @SbloodyS

This still unaddressed. #16576 (comment)

@Xuxiaotuan
Copy link
Author

The front-end and code standards, along with the suggestions for modification, have been revised. Assistance is needed to execute the CI @SbloodyS

This still unaddressed. #16576 (comment)

I didn't notice, there was a PR that had already changed the field name, I have revised and resubmitted it.

SbloodyS
SbloodyS previously approved these changes Sep 19, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix does not address the root cause, which is that the lineage info is not copyed when the workflow is copyed. Would you like to open another PR to fix it? @Xuxiaotuan

This PR is LGTM. Thanks.

@SbloodyS
Copy link
Member

Please run pnpm run lint to format the frontend code. @Xuxiaotuan

@Xuxiaotuan
Copy link
Author

此修复未解决根本原因,即在复制工作流程时未复制沿袭信息。您是否要打开另一个PR来修复此问题?@Xuxiaotuan

我们将努力使您的梦想成真。谢谢。

Ok, I will open another PR to solve the root issue.

@Xuxiaotuan
Copy link
Author

I don't know how to click on it “dismissed”. I'm sorry. It wasn't my intention

@SbloodyS
Copy link
Member

I don't know how to click on it “dismissed”. I'm sorry. It wasn't my intention

It wasn't your clicking. Dissmiss will happen every time you repush the code. This is normal in the process of PR repair.

Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working first time contributor First-time contributor UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to delete copied nodes in unsaved workflow
2 participants