Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16578] Fix environment resource permission #16579

Merged

Conversation

wangxj3
Copy link
Contributor

@wangxj3 wangxj3 commented Sep 4, 2024

Purpose of the pull request

fix #16578

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@SbloodyS SbloodyS added this to the 3.3.0 milestone Sep 5, 2024
@SbloodyS SbloodyS added the bug Something isn't working label Sep 5, 2024
@SbloodyS SbloodyS changed the title [Fix-16578]Fix environment resource permission [Fix-16578] Fix environment resource permission Sep 5, 2024
SbloodyS
SbloodyS previously approved these changes Sep 20, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ruanwenjun
ruanwenjun previously approved these changes Sep 24, 2024
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun force-pushed the fix-EnvironmentResourcePermission-upstream branch from bfe35e0 to c8ff459 Compare September 24, 2024 05:40
SbloodyS
SbloodyS previously approved these changes Sep 24, 2024
@SbloodyS
Copy link
Member

You should check failed UT. @wangxj3

wangxj959 added 2 commits September 25, 2024 18:28
…om:wangxj3/dolphinscheduler into fix-EnvironmentResourcePermission-upstream
@wangxj3 wangxj3 dismissed stale reviews from SbloodyS and ruanwenjun via e674905 September 25, 2024 10:29
@github-actions github-actions bot added the test label Sep 25, 2024
@wangxj3
Copy link
Contributor Author

wangxj3 commented Sep 27, 2024

You should check failed UT. @wangxj3

ok

Copy link

sonarcloud bot commented Sep 29, 2024

@SbloodyS SbloodyS merged commit d2df861 into apache:dev Sep 29, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [api] Only admin users can operate the environment management
3 participants