Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache #16593

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
Open

[Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache #16593

wants to merge 15 commits into from
+7 −47

Conversation

binitshrest
Copy link

@binitshrest binitshrest commented Sep 5, 2024 •
edited by SbloodyS
Loading

I changed and removed the some extra dependencies that should be removed after removing spring-boot-starter-cache from pom.xml and application.properties file. That has caused the issues. After removing extra dependencies and the server runs smoothly with out any bugs

close #16507

@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Sep 5, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

@binitshrest binitshrest changed the title [Improvement-16507][alert] Improve the performance of spring-boot-starter-cache [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache Sep 5, 2024
@binitshrest
Copy link
Author

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
Hi, Can you please review if i updated based on the given documentations.

ruanwenjun
ruanwenjun reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the code and dependency of spring-boot-starter-cache.

@binitshrest
Copy link
Author

We should remove the code and dependency of spring-boot-starter-cache.

Hi ruanwenjun,
After carefully observing and understanding the codebase. I have removed the extra dependency of the spring-boot-starter-cache which includes the related annotations like cacheable and cacheconfig. I removed it and the codebase runs without any issues. I am open for some more suggestions from your side. As spring-boot-starter-cache dependency has been removed from POM.xml and application.properties files. I went some more depth and removed some related annotations.

@binitshrest
Copy link
Author

@caishunfeng Can you please guide me to fix 5 failing issues?

@SbloodyS
Copy link
Member

SbloodyS commented Sep 9, 2024

You should check these two dependency. @binitshrest

log4j-api-2.17.2.jar
log4j-to-slf4j-2.17.2.jar

@binitshrest
Copy link
Author

You should check these two dependency. @binitshrest

log4j-api-2.17.2.jar
log4j-to-slf4j-2.17.2.jar

log4j-to-slf4j-2.17.2.jar

Thank you SbloodyS. I found them. There are so many of these dependencies. Should i remove them too.

@binitshrest
Copy link
Author

You should check these two dependency. @binitshrest

log4j-api-2.17.2.jar
log4j-to-slf4j-2.17.2.jar

log4j-to-slf4j-2.17.2.jar

Thank you @SbloodyS. I found them. There are so many of these dependencies. Should i remove them too.

ruanwenjun
ruanwenjun reviewed Sep 14, 2024
View reviewed changes
...ava/org/apache/dolphinscheduler/plugin/datasource/api/datasource/BaseDataSourceParamDTO.java Outdated
@@ -117,7 +117,7 @@ public void setHostAndPortByAddress(String address) {
}

this.host = String.join(Constants.COMMA, hosts);
this.port = Integer.parseInt(portString);
this.port = (Integer) Integer.parseInt(portString);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not needed

dolphinscheduler-standalone-server/src/main/resources/application.yaml
@@ -1,4 +1,4 @@
#
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not changed.

dolphinscheduler-api/pom.xml
Comment on lines -124 to -127
<exclusion>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-to-slf4j</artifactId>
</exclusion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

dolphinscheduler-bom/pom.xml Outdated
Comment on lines 930 to 933
<exclusion>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-api</artifactId>
</exclusion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

@binitshrest
Copy link
Author

Hi @ruanwenjun,
Sure. I will revert this change asap and will work on this bug. I will appreciate a help from you? My project is failing to build with docker setup and other env setup.

@binitshrest
Copy link
Author

image
Hi @ruanwenjun , the build is succesfully complete.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-actions github-actions bot added the UI ui and front end related label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@Gallardot Gallardot Awaiting requested review from Gallardot

@EricGao888 EricGao888 Awaiting requested review from EricGao888

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@binitshrest binitshrest

Labels
backend UI ui and front end related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement] Remove spring-boot-starter-cache dependency
3 participants
@binitshrest @SbloodyS @ruanwenjun